-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19343: Add hadoop-gcp configuration to core-default.xml and ServiceLoader file. #7916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rviceLoader file.
|
@steveloughran and @mukund-thakur , respectfully requesting review. Thank you! |
|
💔 -1 overall
This message was automatically generated. |
|
@cnauroth From my side, +1, but we need to fix the TestCommonConfigurationFields unit test. |
…rviceLoader file. Closes #7916 Signed-off-by: Shilun Fan <[email protected]>
…rviceLoader file. Closes #7916 Signed-off-by: Shilun Fan <[email protected]>
|
I committed this to the feature branch with the test fix. Thank you, @slfan1989 . |
…rviceLoader file. Closes apache#7916 Signed-off-by: Shilun Fan <[email protected]>
|
@cnauroth given this is in, can you cut thanks |
Description of PR
HADOOP-19343: Add hadoop-gcp configuration to core-default.xml and ServiceLoader file.
This is in sync with configuration documentation here:
https://github.com/apache/hadoop/blob/HADOOP-19343/hadoop-tools/hadoop-gcp/src/site/markdown/tools/hadoop-gcp/Configuration.md
How was this patch tested?
I ran all hadoop-gcp integration tests, and they passed. I also built a distro and manually tested a few
hadoop fscommands targetinggs://URIs.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?