-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11824: Prevent test dependencies from leaking into the distro. #7885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@steveloughran and @slfan1989 , review please? Thank you! |
pan3793
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also spotted this issue today, thank you for fixing it!
@cnauroth Many thanks for spotting and fixing this issue. There are still some follow-up issues with the Jersey upgrade that we’ll need to resolve step by step. |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
Thanks for the reviews, @pan3793 , @slfan1989 and @steveloughran ! I committed this to trunk. |
Description of PR
First, make sure test libraries like jersey-test-framework-provider-jetty are limited to scope test.
Then, update other modules that didn't know they were getting their test dependencies through YARN to depend on test libraries explicitly.
How was this patch tested?
I used
mvn dependency:treeto check that the test dependencies were gone after these changes. Before the changes, we had this in the final distro aftermvn clean package -Pdist -Dtar -DskipTests -DskipShade:After these changes, everything is gone except for the stuff in
hadoop/tools/lib. This is apparently intentional dependencies ofhadoop-tools/hadoop-compat-bench, but it won't creep into the classpath for dependent projects like Parquet.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?