-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19343: Remove JUnit 4 dependencies from hadoop-gcp. #7872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
Author
|
@slfan1989 , can you please reveiw? |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
approved these changes
Aug 15, 2025
Contributor
@cnauroth Thanks for the contribution! LGTM. |
cnauroth
added a commit
that referenced
this pull request
Aug 15, 2025
Closes #7872 Signed-off-by: Shilun Fan <[email protected]>
Contributor
Author
|
@slfan1989 , thank you for the review. |
cnauroth
added a commit
that referenced
this pull request
Aug 15, 2025
Closes #7872 Signed-off-by: Shilun Fan <[email protected]>
cnauroth
added a commit
that referenced
this pull request
Aug 25, 2025
Closes #7872 Signed-off-by: Shilun Fan <[email protected]>
cnauroth
added a commit
to cnauroth/hadoop
that referenced
this pull request
Aug 29, 2025
Closes apache#7872 Signed-off-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Remove JUnit 4 dependencies from hadoop-gcp. Some use of
@Test(expect = ...)needed to be converted toassertThrows.How was this patch tested?
All existing unit tests and integration tests pass after removal of the JUnit 4 dependencies.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?