YARN-11834: Capacity Scheduler Application Stuck In ACCEPTED State due to Race Condition #7806

shameersss1 · 2025-07-16T10:25:58Z

Description of PR

Refer YARN-11834 for detailed information on the race condition

How was this patch tested?

Verified the replication steps mentioned in YARN-11834 by running the application 150+ times
Adding UT is not feasible since this is a race condition.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…e to Race Condition

...java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractLeafQueue.java

hadoop-yetus · 2025-07-16T14:49:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	51m 20s		trunk passed
+1 💚	compile	1m 3s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 55s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	0m 57s		trunk passed
+1 💚	mvnsite	1m 1s		trunk passed
+1 💚	javadoc	0m 58s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 50s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 57s		trunk passed
+1 💚	shadedclient	36m 17s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 50s		the patch passed
+1 💚	compile	0m 56s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 56s		the patch passed
+1 💚	compile	0m 48s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	0m 48s		the patch passed
+1 💚	blanks	0m 1s		The patch has no blanks issues.
+1 💚	checkstyle	0m 42s		the patch passed
+1 💚	mvnsite	0m 51s		the patch passed
+1 💚	javadoc	0m 44s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 42s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 52s		the patch passed
+1 💚	shadedclient	36m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	122m 13s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		262m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7806/1/artifact/out/Dockerfile
GITHUB PR	#7806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 796ae7b2a1e0 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2a10740`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7806/1/testReport/
Max. process+thread count	975 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7806/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

shameersss1 · 2025-07-16T16:34:24Z

Thanks @zeekling for the review
@slfan1989 Could you please review the changes as well?

…e to Race Condition

hadoop-yetus · 2025-07-17T09:59:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	29m 6s		trunk passed
+1 💚	compile	0m 34s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 31s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	0m 32s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	javadoc	0m 38s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 33s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 9s		trunk passed
+1 💚	shadedclient	21m 19s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 27s		the patch passed
+1 💚	compile	0m 31s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 31s		the patch passed
+1 💚	compile	0m 25s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	0m 25s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 21s		the patch passed
+1 💚	mvnsite	0m 31s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 27s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 12s		the patch passed
+1 💚	shadedclient	21m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	113m 11s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 26s		The patch does not generate ASF License warnings.
		194m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7806/2/artifact/out/Dockerfile
GITHUB PR	#7806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux cdbe8247f6ca 5.15.0-142-generic #152-Ubuntu SMP Mon May 19 10:54:31 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `955c012`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7806/2/testReport/
Max. process+thread count	937 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7806/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

shameersss1 · 2025-07-22T05:12:37Z

@slfan1989 - Gentle reminder to review the changes.

slfan1989 · 2025-07-23T05:32:28Z

@shameersss1 LGTM.

Sorry for the late reply — things have been quite busy lately. Thank you for your contribution!

shameersss1 · 2025-07-23T06:57:13Z

Thanks a lot @slfan1989 for the review - Are we good to merge the changes ?

slfan1989 · 2025-07-23T13:24:26Z

Thanks a lot @slfan1989 for the review - Are we good to merge the changes ?

@shameersss1 Thanks for the contribution! Merged into trunk.

…PTED State due to Race Condition (apache#7806) Contributed by Syed Shameerur Rahman. * YARN-11834: Capacity Scheduler Application Stuck In ACCEPTED State due to Race Condition Signed-off-by: Shilun Fan <[email protected]> (cherry picked from commit a0df012) Change-Id: I8bb9215a8f2dda64b62816c9a748f17e42fc85b6

YARN-11834: Capacity Scheduler Application Stuck In ACCEPTED State du…

2a10740

…e to Race Condition

github-actions bot added YARN trunk labels Jul 16, 2025

zeekling reviewed Jul 16, 2025

View reviewed changes

...java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractLeafQueue.java Show resolved Hide resolved

YARN-11834: Capacity Scheduler Application Stuck In ACCEPTED State du…

955c012

…e to Race Condition

shameersss1 requested a review from zeekling July 17, 2025 06:44

zeekling approved these changes Jul 18, 2025

View reviewed changes

slfan1989 approved these changes Jul 23, 2025

View reviewed changes

slfan1989 merged commit a0df012 into apache:trunk Jul 23, 2025
1 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-11834: Capacity Scheduler Application Stuck In ACCEPTED State due to Race Condition #7806

YARN-11834: Capacity Scheduler Application Stuck In ACCEPTED State due to Race Condition #7806

Uh oh!

shameersss1 commented Jul 16, 2025

Uh oh!

Uh oh!

hadoop-yetus commented Jul 16, 2025

Uh oh!

shameersss1 commented Jul 16, 2025

Uh oh!

hadoop-yetus commented Jul 17, 2025

Uh oh!

shameersss1 commented Jul 22, 2025

Uh oh!

slfan1989 commented Jul 23, 2025

Uh oh!

shameersss1 commented Jul 23, 2025

Uh oh!

Uh oh!

slfan1989 commented Jul 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YARN-11834: Capacity Scheduler Application Stuck In ACCEPTED State due to Race Condition #7806

YARN-11834: Capacity Scheduler Application Stuck In ACCEPTED State due to Race Condition #7806

Uh oh!

Conversation

shameersss1 commented Jul 16, 2025

Description of PR

How was this patch tested?

For code changes:

Uh oh!

Uh oh!

hadoop-yetus commented Jul 16, 2025

Uh oh!

shameersss1 commented Jul 16, 2025

Uh oh!

hadoop-yetus commented Jul 17, 2025

Uh oh!

shameersss1 commented Jul 22, 2025

Uh oh!

slfan1989 commented Jul 23, 2025

Uh oh!

shameersss1 commented Jul 23, 2025

Uh oh!

Uh oh!

slfan1989 commented Jul 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants