HADOOP-19436. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-gridmix. #7578

slfan1989 · 2025-04-04T02:44:56Z

Description of PR

JIRA: HADOOP-19436. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-gridmix.

How was this patch tested?

mvn clean test & junit test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2025-04-04T04:59:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 19 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 50s		trunk passed
+1 💚	compile	0m 30s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 31s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 53s		trunk passed
+1 💚	shadedclient	35m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 21s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 22s		the patch passed
+1 💚	compile	0m 19s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 19s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 11 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	0m 18s	/results-checkstyle-hadoop-tools_hadoop-gridmix.txt	hadoop-tools/hadoop-gridmix: The patch generated 65 new + 148 unchanged - 2 fixed = 213 total (was 150)
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	javadoc	0m 22s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 48s		the patch passed
+1 💚	shadedclient	33m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	16m 50s	/patch-unit-hadoop-tools_hadoop-gridmix.txt	hadoop-gridmix in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		133m 6s

Reason	Tests
Failed junit tests	hadoop.mapred.gridmix.TestGridmixSummary
	hadoop.mapred.gridmix.TestGridmixMemoryEmulation

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/1/artifact/out/Dockerfile
GITHUB PR	#7578
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 915eeb034a41 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `adb77fe`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/1/testReport/
Max. process+thread count	1027 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-gridmix U: hadoop-tools/hadoop-gridmix
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth

+1, pending some minor style cleanups flagged in pre-submit. Thank you, @slfan1989 .

hadoop-yetus · 2025-04-07T10:57:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	20m 46s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 19 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 42s		trunk passed
+1 💚	compile	0m 29s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 30s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 51s		trunk passed
+1 💚	shadedclient	33m 51s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 21s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 20s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 20s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 6 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	0m 18s	/results-checkstyle-hadoop-tools_hadoop-gridmix.txt	hadoop-tools/hadoop-gridmix: The patch generated 31 new + 148 unchanged - 2 fixed = 179 total (was 150)
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	javadoc	0m 21s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 48s		the patch passed
+1 💚	shadedclient	33m 47s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	17m 3s	/patch-unit-hadoop-tools_hadoop-gridmix.txt	hadoop-gridmix in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		150m 53s

Reason	Tests
Failed junit tests	hadoop.mapred.gridmix.TestGridmixSummary
	hadoop.mapred.gridmix.TestGridmixMemoryEmulation

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/2/artifact/out/Dockerfile
GITHUB PR	#7578
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 56e023788be9 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b2cbc6f`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/2/testReport/
Max. process+thread count	1041 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-gridmix U: hadoop-tools/hadoop-gridmix
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-04-08T17:46:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 19 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 33s		trunk passed
+1 💚	compile	0m 30s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 31s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 51s		trunk passed
+1 💚	shadedclient	33m 52s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 22s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 22s		the patch passed
+1 💚	compile	0m 19s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 19s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	0m 18s	/results-checkstyle-hadoop-tools_hadoop-gridmix.txt	hadoop-tools/hadoop-gridmix: The patch generated 6 new + 148 unchanged - 2 fixed = 154 total (was 150)
+1 💚	mvnsite	0m 23s		the patch passed
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 49s		the patch passed
+1 💚	shadedclient	33m 57s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 11s		hadoop-gridmix in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		132m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/3/artifact/out/Dockerfile
GITHUB PR	#7578
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 7618860ea779 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `95640c9`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/3/testReport/
Max. process+thread count	1005 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-gridmix U: hadoop-tools/hadoop-gridmix
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-04-09T03:46:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 0s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 19 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 7s		trunk passed
+1 💚	compile	0m 29s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 33s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 52s		trunk passed
+1 💚	shadedclient	36m 51s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 22s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 21s		the patch passed
+1 💚	compile	0m 19s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		hadoop-tools/hadoop-gridmix: The patch generated 0 new + 148 unchanged - 2 fixed = 148 total (was 150)
+1 💚	mvnsite	0m 23s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 48s		the patch passed
+1 💚	shadedclient	34m 23s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 38s		hadoop-gridmix in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		135m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/4/artifact/out/Dockerfile
GITHUB PR	#7578
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 9cc35f3698c7 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d5e08e1`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/4/testReport/
Max. process+thread count	1020 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-gridmix U: hadoop-tools/hadoop-gridmix
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7578/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-04-09T12:42:09Z

@cnauroth Thank you very much for reviewing the code! Yetus indicates that this PR is ready to be merged. I will merge this PR into the trunk branch.

HADOOP-19436. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-gridmix.

adb77fe

github-actions bot added trunk TOOLS labels Apr 4, 2025

cnauroth approved these changes Apr 4, 2025

View reviewed changes

HADOOP-19436. Fix CheckStyle.

b2cbc6f

HADOOP-19436. Fix CheckStyle & Junit Test.

95640c9

HADOOP-19436. Fix CheckStyle & Junit Test.

d5e08e1

slfan1989 marked this pull request as ready for review April 9, 2025 01:29

slfan1989 merged commit a38294d into apache:trunk Apr 9, 2025
4 checks passed

slfan1989 mentioned this pull request Apr 25, 2025

[DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. #7337

Draft

75 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-19436. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-gridmix. #7578

HADOOP-19436. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-gridmix. #7578

Uh oh!

slfan1989 commented Apr 4, 2025 •

edited

Loading

Uh oh!

hadoop-yetus commented Apr 4, 2025

Uh oh!

cnauroth left a comment

Uh oh!

hadoop-yetus commented Apr 7, 2025

Uh oh!

hadoop-yetus commented Apr 8, 2025

Uh oh!

hadoop-yetus commented Apr 9, 2025

Uh oh!

Uh oh!

slfan1989 commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HADOOP-19436. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-gridmix. #7578

HADOOP-19436. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-gridmix. #7578

Uh oh!

Conversation

slfan1989 commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Apr 4, 2025

Uh oh!

cnauroth left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Apr 7, 2025

Uh oh!

hadoop-yetus commented Apr 8, 2025

Uh oh!

hadoop-yetus commented Apr 9, 2025

Uh oh!

Uh oh!

slfan1989 commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

slfan1989 commented Apr 4, 2025 •

edited

Loading