Skip to content

Conversation

@slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Feb 13, 2025

Description of PR

JIRA: HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part1.

How was this patch tested?

Junit Test.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@slfan1989 slfan1989 changed the title HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part1. HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part1. Feb 13, 2025
@slfan1989
Copy link
Contributor Author

@cnauroth Could you help review this PR? Thank you very much!

During the upgrade of hadoop-common, I upgraded TestListFiles and CryptoStreamsTestBase, but I did not update their subclasses. As a result, HDFS unit tests are currently showing errors related to the subclasses not being executable. I originally planned to address this in #7375, but this PR is expected to take some time to complete.

Given that a new feature in HDFS (ARR, Aynchronous Router RPC, #7308) is about to be released, I decided to submit this quick fix PR to avoid affecting their plans.

cc: @Hexiaoqiao @KeeProMise

@KeeProMise
Copy link
Member

@slfan1989 thanks for your work. LGTM.

Copy link
Contributor

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 32s trunk passed
+1 💚 compile 1m 19s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 compile 1m 11s trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 checkstyle 1m 8s trunk passed
+1 💚 mvnsite 1m 17s trunk passed
+1 💚 javadoc 1m 9s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 1m 37s trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 3m 9s trunk passed
+1 💚 shadedclient 35m 57s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 4s the patch passed
+1 💚 compile 1m 12s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javac 1m 12s the patch passed
+1 💚 compile 1m 2s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 javac 1m 2s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 57s the patch passed
+1 💚 mvnsite 1m 5s the patch passed
+1 💚 javadoc 0m 59s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 1m 31s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 3m 7s the patch passed
+1 💚 shadedclient 35m 57s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 1m 34s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
130m 43s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7383/1/artifact/out/Dockerfile
GITHUB PR #7383
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 78c7f2b6bc19 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1c9ea05
Default Java Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7383/1/testReport/
Max. process+thread count 559 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7383/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @slfan1989 .

@slfan1989 slfan1989 merged commit 6e7511c into apache:trunk Feb 14, 2025
4 checks passed
@slfan1989
Copy link
Contributor Author

@cnauroth @Hexiaoqiao @KeeProMise Thanks for the review! Merged into trunk.

adideshpande pushed a commit to adideshpande/hadoop that referenced this pull request Feb 27, 2025
)

Co-authored-by: Chris Nauroth <[email protected]>
Co-authored-by: He Xiaoqiao <[email protected]>
Co-authored-by: Jian Zhang <[email protected]>
Reviewed-by: Chris Nauroth <[email protected]>
Reviewed-by: He Xiaoqiao <[email protected]>
Reviewed-by: Jian Zhang <[email protected]>
Signed-off-by: Shilun Fan <[email protected]>
YanivKunda pushed a commit to YanivKunda/hadoop that referenced this pull request Mar 23, 2025
)

Co-authored-by: Chris Nauroth <[email protected]>
Co-authored-by: He Xiaoqiao <[email protected]>
Co-authored-by: Jian Zhang <[email protected]>
Reviewed-by: Chris Nauroth <[email protected]>
Reviewed-by: He Xiaoqiao <[email protected]>
Reviewed-by: Jian Zhang <[email protected]>
Signed-off-by: Shilun Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants