-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part1. #7383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cnauroth Could you help review this PR? Thank you very much! During the upgrade of Given that a new feature in HDFS (ARR, Aynchronous Router RPC, #7308) is about to be released, I decided to submit this quick fix PR to avoid affecting their plans. |
|
@slfan1989 thanks for your work. LGTM. |
Hexiaoqiao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1.
|
🎊 +1 overall
This message was automatically generated. |
cnauroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you @slfan1989 .
|
@cnauroth @Hexiaoqiao @KeeProMise Thanks for the review! Merged into trunk. |
) Co-authored-by: Chris Nauroth <[email protected]> Co-authored-by: He Xiaoqiao <[email protected]> Co-authored-by: Jian Zhang <[email protected]> Reviewed-by: Chris Nauroth <[email protected]> Reviewed-by: He Xiaoqiao <[email protected]> Reviewed-by: Jian Zhang <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
) Co-authored-by: Chris Nauroth <[email protected]> Co-authored-by: He Xiaoqiao <[email protected]> Co-authored-by: Jian Zhang <[email protected]> Reviewed-by: Chris Nauroth <[email protected]> Reviewed-by: He Xiaoqiao <[email protected]> Reviewed-by: Jian Zhang <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Description of PR
JIRA: HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part1.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?