HDDS-1368. Cleanup old ReplicationManager code from SCM. #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
mukul1987
requested changes
Apr 17, 2019
Contributor
mukul1987
left a comment
mukul1987
left a comment
There was a problem hiding this comment.
The changes generally looks good to me. Some minor comments.
Contributor
There was a problem hiding this comment.
DeleteBlock handler is the only user of CommandWatcher now ?
Contributor
Author
There was a problem hiding this comment.
Yes, no other command uses CommandWatcher anymore.
Contributor
There was a problem hiding this comment.
Should closeContainer happen before destroy pipeline, so that we close container cleanly ?
Contributor
Author
There was a problem hiding this comment.
TLDR; destoryPipelines internally calls close container already.
There are three stages where we close the containers when a datanode goes dead
- When the node is marked as stale, we destroy the pipeline which will try to close the containers cleanly.
(Finalizing and destroying the pipeline after the timeout)
-> When the node is marked as dead
2. destroyPipelines(datanodeDetails) --> call
Here we destroy the pipeline which will also try to close the containers, here we don't try to close the container cleanly. This is a fallback mechanism, if everything was working fine we should not have any pipelines at this point.
(Finalizing and destroying the pipeline without timeout)
- closeContainers(datanodeDetails, publisher) --> call
This is the last resort for closing a container, it is to handle a weird case where there is open container and it is not part of any pipeline. [This can (or) should not happen]
nandakumar131
force-pushed
the
HDDS-1368
branch
from
3688911 to
2d4f6b6
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
/retest |
mukul1987
approved these changes
Apr 23, 2019
Signed-off-by: Akira Ajisaka <[email protected]>
…dfs-default.xml Signed-off-by: Masatake Iwasaki <[email protected]>
… Contributed by Yishuang Lu. (apache#747)
…acOS. Contributed by Siyao Meng. Signed-off-by: Wei-Chiu Chuang <[email protected]>
…ements Signed-off-by: Akira Ajisaka <[email protected]>
… due to typos. Contributed by Wanqiang Ji.
Contributed by Prabhu Joseph
Contributed by Siyao Meng
…e Chen. (apache#661) Signed-off-by: Xiaoyu Yao <[email protected]>
…ontributed by Abhishek Modi.
…Contributed by Eric Yang
…r module. Contributed by Tao Yang.
…correct units when the default value is used. Contributed by starphin.
…AM heartbeat. Contributed by Abhishek Modi.
…unk. Contributed by Ayush Saxena.
… handle StandbyException when fetching HAServiceState. Contributed by Erik Krogen.
…ationTokenSecretManager. Contributed by CR Hota.
Contributed by Yesha Vora
Contributed by Dinesh Chitlangia.
…ontributed by Prabhu Joseph.
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Author: Jagadish <[email protected]> Reviewers: Jagadish<[email protected]> Closes apache#711 from vjagadish1989/website-reorg8
susheelgupta7
pushed a commit
to susheel-gupta/hadoop
that referenced
this pull request
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #620 brings in new ReplicationManager and PR #662 plugs in the new code, this is for removing the old ReplicationManager and related code.