-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19238. Fix create-release script for arm64 based MacOS #6962
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
dev-support/bin/create-release
Outdated
@@ -523,7 +523,6 @@ function dockermode | |||
echo "USER ${user_name}" | |||
printf "\n\n" | |||
) | docker build -t "${imgname}" -f - "${BASEDIR}"/dev-support/docker/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unnecessary change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 once fix the unnecessary change @pan3793 mentioned above.
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1
merged to trunk and testing; you can backport |
Contributed by Mukund Thakur
…#6962) Contributed by Mukund Thakur
…#6962) Contributed by Mukund Thakur
Description of PR
Add proper checks for arm64 based machine.
How was this patch tested?
Tested on MacOS
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?