Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-11705. Turn off Node Manager working directories validation by default #6948

Merged
merged 1 commit into from
Jul 18, 2024
Merged

YARN-11705. Turn off Node Manager working directories validation by default #6948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...oop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2189,7 +2189,7 @@ public static boolean isAclEnabled(Configuration conf) {
NM_DISK_HEALTH_CHECK_PREFIX + "working-dir-content-accessibility-validation.enabled";

public static final boolean DEFAULT_NM_WORKING_DIR_CONTENT_ACCESSIBILITY_VALIDATION_ENABLED =
true;
false;

/** The health checker scripts. */
public static final String NM_HEALTH_CHECK_SCRIPTS =
Expand Down
2 changes: 1 addition & 1 deletion hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1998,7 +1998,7 @@
<property>
<description>Validate content of the node manager directories can be accessed</description>
<name>yarn.nodemanager.disk-health-checker.working-dir-content-accessibility-validation.enabled</name>
<value>true</value>
<value>false</value>
</property>

<property>
Expand Down
5 changes: 5 additions & 0 deletions ...emanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DirectoryCollection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,4 +726,9 @@ private void setGoodDirsDiskUtilizationPercentage() {
public int getGoodDirsDiskUtilizationPercentage() {
return goodDirsDiskUtilizationPercentage;
}

@VisibleForTesting
public void setSubAccessibilityValidationEnabled(boolean subAccessibilityValidationEnabled) {
this.subAccessibilityValidationEnabled = subAccessibilityValidationEnabled;
}
}
1 change: 1 addition & 0 deletions ...ager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDirectoryCollection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,7 @@ public void testNonAccessibleSub() throws IOException {
Files.setPosixFilePermissions(testFile.toPath(),
PosixFilePermissions.fromString("-w--w--w-"));
DirectoryCollection dc = new DirectoryCollection(new String[]{testDir.toString()});
dc.setSubAccessibilityValidationEnabled(true);
Map<String, DirectoryCollection.DiskErrorInformation> diskErrorInformationMap =
dc.testDirs(Collections.singletonList(testDir.toString()), Collections.emptySet());
Assert.assertEquals(1, diskErrorInformationMap.size());
Expand Down
Loading