Skip to content

Conversation

@yzhang559
Copy link
Contributor

@yzhang559 yzhang559 commented Apr 26, 2024

Description of PR

Depends on PR #6860

JIRA = HDFS-17540
The ekek cache warm up thread should not fail the whole warmup of other keys if an invalid key is encountered.
We have observed infinite retries to KMS if one of Encryption Key is not available.

Change it to

  • Continue to warmup other keys, throw IOException at last
  • Add a retry limit config

How was this patch tested?

Added unit test TestFSDirEncryptionZoneOp for retry behavior

Related unit tests

mvn test -Dtest=TestEncryptionZones,TestEncryptionZonesWithKMS,TestFSDirEncryptionZoneOp

[INFO] Running org.apache.hadoop.hdfs.TestEncryptionZones
[INFO] Tests run: 44, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 137.217 s - in org.apache.hadoop.hdfs.TestEncryptionZones
[INFO] Running org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS
[INFO] Tests run: 47, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 187.815 s - in org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS
[INFO] Running org.apache.hadoop.hdfs.server.namenode.TestFSDirEncryptionZoneOp
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.331 s - in org.apache.hadoop.hdfs.server.namenode.TestFSDirEncryptionZoneOp

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? NA
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0? NA
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files? NA

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 52s Maven dependency ordering for branch
+1 💚 mvninstall 37m 8s trunk passed
+1 💚 compile 19m 7s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 18m 11s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 checkstyle 4m 43s trunk passed
+1 💚 mvnsite 3m 57s trunk passed
+1 💚 javadoc 3m 8s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 3m 20s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 6m 53s trunk passed
+1 💚 shadedclient 41m 33s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
+1 💚 mvninstall 2m 30s the patch passed
+1 💚 compile 18m 28s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 18m 28s the patch passed
+1 💚 compile 18m 30s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 javac 18m 30s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 37s the patch passed
+1 💚 mvnsite 3m 53s the patch passed
+1 💚 javadoc 3m 1s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 3m 16s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 7m 23s the patch passed
+1 💚 shadedclient 41m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 2s hadoop-common in the patch passed.
+1 💚 unit 3m 50s hadoop-kms in the patch passed.
-1 ❌ unit 263m 51s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
-1 ❌ asflicense 1m 8s /results-asflicense.txt The patch generated 1 ASF License warnings.
549m 30s
Reason Tests
Failed junit tests hadoop.hdfs.TestRollingUpgrade
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6774/1/artifact/out/Dockerfile
GITHUB PR #6774
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 50f4cb272f31 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f0e0386
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6774/1/testReport/
Max. process+thread count 3328 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6774/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 01s No case conflicting files found.
+0 🆗 spotbugs 0m 01s spotbugs executables are not available.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+0 🆗 xmllint 0m 01s xmllint was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 16s Maven dependency ordering for branch
+1 💚 mvninstall 91m 46s trunk passed
+1 💚 compile 40m 45s trunk passed
+1 💚 checkstyle 6m 01s trunk passed
-1 ❌ mvnsite 4m 26s /branch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in trunk failed.
+1 💚 javadoc 15m 25s trunk passed
+1 💚 shadedclient 172m 44s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 2m 18s Maven dependency ordering for patch
+1 💚 mvninstall 12m 21s the patch passed
+1 💚 compile 38m 15s the patch passed
+1 💚 javac 38m 15s the patch passed
+1 💚 blanks 0m 00s The patch has no blanks issues.
+1 💚 checkstyle 6m 12s the patch passed
-1 ❌ mvnsite 4m 35s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 💚 javadoc 15m 13s the patch passed
+1 💚 shadedclient 183m 04s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ asflicense 5m 52s /results-asflicense.txt The patch generated 1 ASF License warnings.
556m 36s
Subsystem Report/Notes
GITHUB PR #6774
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname MINGW64_NT-10.0-17763 26e5efede4c6 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / f0e0386
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6774/1/testReport/
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6774/1/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 02s No case conflicting files found.
+0 🆗 spotbugs 0m 01s spotbugs executables are not available.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+0 🆗 xmllint 0m 01s xmllint was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 6m 23s Maven dependency ordering for branch
+1 💚 mvninstall 130m 49s trunk passed
+1 💚 compile 61m 01s trunk passed
+1 💚 checkstyle 9m 30s trunk passed
-1 ❌ mvnsite 6m 49s /branch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in trunk failed.
+1 💚 javadoc 23m 26s trunk passed
+1 💚 shadedclient 256m 54s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 3m 30s Maven dependency ordering for patch
+1 💚 mvninstall 18m 36s the patch passed
+1 💚 compile 56m 38s the patch passed
+1 💚 javac 56m 38s the patch passed
+1 💚 blanks 0m 01s The patch has no blanks issues.
+1 💚 checkstyle 9m 10s the patch passed
-1 ❌ mvnsite 6m 55s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 💚 javadoc 22m 55s the patch passed
+1 💚 shadedclient 263m 03s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ asflicense 8m 50s /results-asflicense.txt The patch generated 1 ASF License warnings.
815m 43s
Subsystem Report/Notes
GITHUB PR #6774
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname MINGW64_NT-10.0-17763 5f2bdf72e508 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / f0e0386
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6774/2/testReport/
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6774/2/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 02s No case conflicting files found.
+0 🆗 spotbugs 0m 00s spotbugs executables are not available.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+0 🆗 xmllint 0m 01s xmllint was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 2m 18s Maven dependency ordering for branch
+1 💚 mvninstall 92m 35s trunk passed
+1 💚 compile 41m 14s trunk passed
+1 💚 checkstyle 6m 25s trunk passed
-1 ❌ mvnsite 4m 36s /branch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in trunk failed.
+1 💚 javadoc 15m 58s trunk passed
+1 💚 shadedclient 179m 02s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 2m 31s Maven dependency ordering for patch
+1 💚 mvninstall 12m 28s the patch passed
+1 💚 compile 37m 59s the patch passed
+1 💚 javac 37m 59s the patch passed
+1 💚 blanks 0m 00s The patch has no blanks issues.
+1 💚 checkstyle 6m 14s the patch passed
-1 ❌ mvnsite 4m 50s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 💚 javadoc 16m 21s the patch passed
+1 💚 shadedclient 188m 11s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 5m 54s The patch does not generate ASF License warnings.
568m 35s
Subsystem Report/Notes
GITHUB PR #6774
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname MINGW64_NT-10.0-17763 144c7ee9888d 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 10d763a
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6774/3/testReport/
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6774/3/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@simbadzina simbadzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned will changing the contract of warmUpEncryptedKeys from

exception if any key isn't initialized

to

exception only if all keys can't be initialized

You can still like the number of retries, without changing the above.

@yzhang559 yzhang559 force-pushed the HDFS-13603 branch 2 times, most recently from 8574577 to 77d14b7 Compare May 28, 2024 16:57
@simbadzina simbadzina self-requested a review May 29, 2024 20:03
Copy link
Member

@simbadzina simbadzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@simbadzina simbadzina dismissed their stale review May 29, 2024 21:15

Comments addressed.

@simbadzina
Copy link
Member

Could you please to carve out the changes in hadoop-common into a separate PR. I'm suspecting this may be what is causing the CI tests to hang and fail.

Besides the CI tests, keeping the changes contained within a module is cleaner for maintainability and modularity.

@simbadzina simbadzina removed the Common label May 31, 2024
@yzhang559 yzhang559 changed the title HDFS-13603: do not propagate ExecutionException and add maxRetries li… HDFS-17540: do not propagate ExecutionException and add maxRetries li… May 31, 2024
@github-actions github-actions bot added the Common label Jun 3, 2024
@yzhang559 yzhang559 force-pushed the HDFS-13603 branch 2 times, most recently from 154e46e to 87a4d12 Compare June 3, 2024 17:07
@simbadzina simbadzina removed the Common label Jun 3, 2024
@simbadzina simbadzina changed the title HDFS-17540: do not propagate ExecutionException and add maxRetries li… HDFS-17540: Do not propagate ExecutionException and add maxRetries limit to NameNode edek cache warmup Jun 6, 2024
@simbadzina simbadzina self-requested a review June 6, 2024 20:27
@simbadzina simbadzina requested a review from CloudZY June 6, 2024 20:27
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 17m 47s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 49m 52s trunk passed
+1 💚 compile 1m 23s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 compile 1m 14s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 checkstyle 1m 14s trunk passed
+1 💚 mvnsite 1m 22s trunk passed
+1 💚 javadoc 1m 9s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 1m 40s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 spotbugs 3m 19s trunk passed
+1 💚 shadedclient 41m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 11s the patch passed
+1 💚 compile 1m 15s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javac 1m 15s the patch passed
+1 💚 compile 1m 6s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 javac 1m 6s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 4s /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 313 unchanged - 0 fixed = 314 total (was 313)
+1 💚 mvnsite 1m 14s the patch passed
+1 💚 javadoc 0m 56s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 1m 35s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 spotbugs 3m 18s the patch passed
+1 💚 shadedclient 42m 5s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 262m 40s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
435m 19s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6774/18/artifact/out/Dockerfile
GITHUB PR #6774
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux b8b87f6b45ee 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e3a6326
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6774/18/testReport/
Max. process+thread count 3056 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6774/18/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@simbadzina simbadzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simbadzina simbadzina merged commit b4ddb2d into apache:trunk Jun 24, 2024
KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Sep 9, 2024
Hexiaoqiao pushed a commit to Hexiaoqiao/hadoop that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants