HDDS-1355. Only FQDN is accepted for OM rpc address in secure environment. Contributed by Ajay Kumar.

[ajayydv]

No description provided.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	25	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	57	Maven dependency ordering for branch
+1	mvninstall	1091	trunk passed
+1	compile	104	trunk passed
+1	checkstyle	28	trunk passed
+1	mvnsite	75	trunk passed
+1	shadedclient	758	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	46	trunk passed
+1	javadoc	46	trunk passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	70	the patch passed
+1	compile	93	the patch passed
+1	javac	93	the patch passed
+1	checkstyle	21	the patch passed
+1	mvnsite	52	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	690	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	43	the patch passed
+1	javadoc	30	the patch passed
		_ Other Tests _
+1	unit	39	ozone-manager in the patch passed.
-1	unit	1078	integration-test in the patch failed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		4439

Reason	Tests
Failed junit tests	hadoop.ozone.TestMiniChaosOzoneCluster

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-677/1/artifact/out/Dockerfile
GITHUB PR	#677
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux a86d61a09e9b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / ab2bda5
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-677/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-677/1/testReport/
Max. process+thread count	4992 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-677/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[elek]

+1. I tested it in my environment and NPE is replaced with a more meaningful error:

2019-04-02 13:05:50 ERROR OzoneManager:872 - Failed to start the OzoneManager.
java.lang.RuntimeException: Can't get SCM signed certificate. omRpcAdd: om-0.om:9862
	at org.apache.hadoop.ozone.om.OzoneManager.getSCMSignedCert(OzoneManager.java:1379)
	at org.apache.hadoop.ozone.om.OzoneManager.initializeSecurity(OzoneManager.java:1025)
	at org.apache.hadoop.ozone.om.OzoneManager.omInit(OzoneManager.java:978)
	at org.apache.hadoop.ozone.om.OzoneManager.createOm(OzoneManager.java:935)
	at org.apache.hadoop.ozone.om.OzoneManager.main(OzoneManager.java:866)
2019-04-02 13:05:50 INFO  ExitUtil:210 - Exiting with status 1: java.lang.RuntimeException: Can't get SCM signed certificate. omRpcAdd: om-0.om:9862

Note: This patch doesn't solve the DNS resolution problem. We did some debug with @ajayydv and we found that the reverse dns resolution works in the containers based on simple domain names (om-0.om) but not in java. But that's a different problem. Using meaningful error instead of NPE is good enough for now...

[elek]

Merged it to 0.4/trunk. Thanks @ajayydv the fix.