-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19137. [ABFS] Prevent ABFS initialization for non-hierarchal-namespace account if Customer-provided-key configs given. #6752
HADOOP-19137. [ABFS] Prevent ABFS initialization for non-hierarchal-namespace account if Customer-provided-key configs given. #6752
Conversation
…guardrail to assert that fs init would fail
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
This reverts commit 794685c.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
:::: AGGREGATED TEST RESULT :::: ============================================================
|
...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Thank you @steveloughran very much for the review. Have taken the comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I think my concerns are addressed
@saxenapranav |
Thank you @steveloughran very much! Following can be used for the merge commit: Title: Prevent ABFS initialization for non-hierarchal-namespace account if Customer-provided-key configs given. Body: |
Hi @steveloughran @mukund-thakur , thanks for the approval. I have added one more commit post approval regarding correction of CPK abbreviation in the patch. Requesting you to kindly merge the PR please if the merge-commit-message looks good. Thank you very much! |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
merged to trunk, Please create a backport on merged to trunk. Can you do the branch-3.4 cherrypick, rerun the tests and then push up as a PR to merge there too? thanks |
…amespace account if Customer-provided-key configs given. (apache#6752) Customer-provided-keys (CPK) configs are not allowed with non-hierarchal-namespace (non-HNS) accounts for ABFS. This patch aims to prevent ABFS initialization for non-HNS accounts if CPK configs are provided. Contributed by: Pranav Saxena
Thanks @mukund-thakur very much! I have created a backport pr: #6880. Thanks! |
…amespace account if Customer-provided-key configs given. (#6752) (#6880) Customer-provided-keys (CPK) configs are not allowed with non-hierarchal-namespace (non-HNS) accounts for ABFS. This patch aims to prevent ABFS initialization for non-HNS accounts if CPK configs are provided. Contributed by: Pranav Saxena
…amespace account if Customer-provided-key configs given. (apache#6752) Customer-provided-keys (CPK) configs are not allowed with non-hierarchal-namespace (non-HNS) accounts for ABFS. This patch aims to prevent ABFS initialization for non-HNS accounts if CPK configs are provided. Contributed by: Pranav Saxena
…amespace account if Customer-provided-key configs given. (apache#6752) Customer-provided-keys (CPK) configs are not allowed with non-hierarchal-namespace (non-HNS) accounts for ABFS. This patch aims to prevent ABFS initialization for non-HNS accounts if CPK configs are provided. Contributed by: Pranav Saxena
jira: https://issues.apache.org/jira/browse/HADOOP-19137
CPK configs are only allowed on hns account. This PR aims to fail fs init in case CPK configs are given and the account given is non-hns.
Following are the CPK options:
EncryptionContextProvider
, which can create the key and sha-key:::: AGGREGATED TEST RESULT ::::
============================================================
HNS-OAuth
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 2
[WARNING] Tests run: 623, Failures: 0, Errors: 0, Skipped: 73
[WARNING] Tests run: 380, Failures: 0, Errors: 0, Skipped: 57
============================================================
HNS-SharedKey
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 623, Failures: 0, Errors: 0, Skipped: 28
[WARNING] Tests run: 380, Failures: 0, Errors: 0, Skipped: 41
============================================================
NonHNS-SharedKey
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 9
[ERROR] Tests run: 623, Failures: 0, Errors: 0, Skipped: 248
[WARNING] Tests run: 380, Failures: 0, Errors: 0, Skipped: 44
============================================================
AppendBlob-HNS-OAuth
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 2
[WARNING] Tests run: 623, Failures: 0, Errors: 0, Skipped: 75
[WARNING] Tests run: 380, Failures: 0, Errors: 0, Skipped: 81
Time taken: 20 mins 51 secs.
azureuser@Hadoop-VM-EAST2:
/hadoop/hadoop-tools/hadoop-azure$/hadoop/hadoop-tools/hadoop-azure$ git logazureuser@Hadoop-VM-EAST2:
commit 60853e0 (HEAD -> saxenapranav/failFsInitOnCpkNonHns, origin/saxenapranav/failFsInitOnCpkNonHns)
Author: Pranav Saxena <>
Date: Fri Apr 19 06:05:17 2024 -0700