Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-19134. Use StringBuilder instead of StringBuffer. #6692

Merged
merged 8 commits into from
Aug 18, 2024
Merged

HADOOP-19134. Use StringBuilder instead of StringBuffer. #6692

merged 8 commits into from
Aug 18, 2024

Conversation

pjfanning
Copy link
Contributor

Description of PR

HADOOP-19134

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 2s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 55 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 44s Maven dependency ordering for branch
+1 💚 mvninstall 32m 28s trunk passed
+1 💚 compile 17m 9s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 15m 45s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 checkstyle 4m 49s trunk passed
+1 💚 mvnsite 16m 53s trunk passed
+1 💚 javadoc 14m 56s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 14m 55s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 26m 46s trunk passed
+1 💚 shadedclient 33m 53s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 30s /patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 compile 16m 26s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 16m 26s the patch passed
-1 ❌ compile 6m 39s /patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
-1 ❌ javac 6m 39s /patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 4m 43s /results-checkstyle-root.txt root: The patch generated 3 new + 3930 unchanged - 6 fixed = 3933 total (was 3936)
-1 ❌ mvnsite 0m 56s /patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 javadoc 14m 50s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 14m 53s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
-1 ❌ spotbugs 0m 53s /patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
-1 ❌ shadedclient 9m 0s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 28s hadoop-common in the patch passed.
+1 💚 unit 3m 53s hadoop-kms in the patch passed.
-1 ❌ unit 229m 30s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 1m 30s hadoop-yarn-api in the patch passed.
-1 ❌ unit 1m 10s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 unit 4m 14s hadoop-yarn-server-common in the patch passed.
+1 💚 unit 105m 51s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 24m 49s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 28m 50s hadoop-yarn-client in the patch passed.
+1 💚 unit 7m 47s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 1m 44s hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 9m 12s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 4m 38s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 unit 128m 0s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 unit 1m 8s hadoop-yarn-server-router in the patch passed.
+1 💚 unit 1m 33s hadoop-mapreduce-examples in the patch passed.
+1 💚 unit 7m 21s hadoop-streaming in the patch passed.
+1 💚 asflicense 1m 24s The patch does not generate ASF License warnings.
908m 41s
Reason Tests
Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/1/artifact/out/Dockerfile
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 08d1c85b3751 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 45ab789
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/1/testReport/
Max. process+thread count 4051 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 22s No case conflicting files found.
+0 🆗 spotbugs 0m 01s spotbugs executables are not available.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 55 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 06s Maven dependency ordering for branch
+1 💚 mvninstall 108m 51s trunk passed
+1 💚 compile 47m 49s trunk passed
+1 💚 checkstyle 7m 17s trunk passed
-1 ❌ mvnsite 5m 17s /branch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in trunk failed.
+1 💚 javadoc 95m 17s trunk passed
+1 💚 shadedclient 373m 49s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 2m 48s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 14s /patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
-1 ❌ compile 29m 37s /patch-compile-root.txt root in the patch failed.
-1 ❌ javac 29m 37s /patch-compile-root.txt root in the patch failed.
+1 💚 blanks 0m 01s The patch has no blanks issues.
+1 💚 checkstyle 6m 06s the patch passed
-1 ❌ mvnsite 4m 06s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
-1 ❌ mvnsite 4m 28s /patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 javadoc 74m 51s the patch passed
-1 ❌ shadedclient 220m 04s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 5m 14s The patch does not generate ASF License warnings.
872m 01s
Subsystem Report/Notes
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname MINGW64_NT-10.0-17763 15c8e8eb8429 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 45ab789
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6692/1/testReport/
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6692/1/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning pjfanning force-pushed the HADOOP-19134-stringbuilder branch from 814de6c to 1767c00 Compare April 24, 2024 20:04
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 2s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 56 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 53s Maven dependency ordering for branch
+1 💚 mvninstall 32m 10s trunk passed
+1 💚 compile 17m 6s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 15m 38s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 checkstyle 4m 48s trunk passed
+1 💚 mvnsite 19m 5s trunk passed
+1 💚 javadoc 16m 42s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 16m 41s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 29m 47s trunk passed
+1 💚 shadedclient 34m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 29s /patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 compile 16m 32s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 16m 32s the patch passed
-1 ❌ compile 6m 49s /patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
-1 ❌ javac 6m 49s /patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 5m 13s /results-checkstyle-root.txt root: The patch generated 3 new + 3956 unchanged - 6 fixed = 3959 total (was 3962)
-1 ❌ mvnsite 0m 54s /patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 javadoc 16m 35s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 16m 32s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
-1 ❌ spotbugs 0m 49s /patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
-1 ❌ shadedclient 9m 3s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 21s hadoop-common in the patch passed.
+1 💚 unit 3m 47s hadoop-kms in the patch passed.
-1 ❌ unit 226m 40s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 1m 19s hadoop-yarn-api in the patch passed.
-1 ❌ unit 0m 57s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 unit 4m 4s hadoop-yarn-server-common in the patch passed.
+1 💚 unit 105m 30s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 24m 39s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 28m 38s hadoop-yarn-client in the patch passed.
+1 💚 unit 7m 40s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 1m 36s hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 9m 1s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 4m 35s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 unit 127m 15s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 unit 24m 5s hadoop-distcp in the patch passed.
+1 💚 unit 1m 5s hadoop-yarn-server-router in the patch passed.
+1 💚 unit 1m 25s hadoop-mapreduce-examples in the patch passed.
+1 💚 unit 7m 28s hadoop-streaming in the patch passed.
+1 💚 unit 1m 6s hadoop-rumen in the patch passed.
+1 💚 unit 1m 11s hadoop-datajoin in the patch passed.
+1 💚 unit 3m 26s hadoop-aws in the patch passed.
+1 💚 asflicense 1m 24s The patch does not generate ASF License warnings.
953m 13s
Reason Tests
Failed junit tests hadoop.hdfs.server.datanode.TestLargeBlockReport
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/3/artifact/out/Dockerfile
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux dcb1ee7e39d6 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1767c00
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/3/testReport/
Max. process+thread count 3841 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 3s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 56 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 59s Maven dependency ordering for branch
+1 💚 mvninstall 32m 41s trunk passed
+1 💚 compile 17m 36s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 16m 9s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 checkstyle 4m 47s trunk passed
+1 💚 mvnsite 20m 8s trunk passed
+1 💚 javadoc 17m 47s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 17m 40s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 31m 13s trunk passed
+1 💚 shadedclient 34m 26s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 30s /patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 compile 16m 53s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 16m 53s the patch passed
-1 ❌ compile 6m 50s /patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
-1 ❌ javac 6m 50s /patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 5m 14s /results-checkstyle-root.txt root: The patch generated 3 new + 3954 unchanged - 6 fixed = 3957 total (was 3960)
-1 ❌ mvnsite 0m 57s /patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 javadoc 17m 46s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 17m 36s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
-1 ❌ spotbugs 0m 52s /patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
-1 ❌ shadedclient 9m 18s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 35s hadoop-common in the patch passed.
+1 💚 unit 3m 52s hadoop-kms in the patch passed.
+1 💚 unit 226m 18s hadoop-hdfs in the patch passed.
+1 💚 unit 1m 28s hadoop-yarn-api in the patch passed.
-1 ❌ unit 1m 3s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt hadoop-yarn-common in the patch failed.
+1 💚 unit 4m 2s hadoop-yarn-server-common in the patch passed.
+1 💚 unit 105m 36s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 24m 49s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 28m 53s hadoop-yarn-client in the patch passed.
+1 💚 unit 7m 52s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 1m 41s hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 9m 9s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 4m 39s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 unit 128m 14s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 unit 24m 10s hadoop-distcp in the patch passed.
+1 💚 unit 1m 10s hadoop-yarn-server-router in the patch passed.
+1 💚 unit 1m 32s hadoop-mapreduce-examples in the patch passed.
+1 💚 unit 7m 34s hadoop-streaming in the patch passed.
+1 💚 unit 1m 13s hadoop-rumen in the patch passed.
+1 💚 unit 1m 16s hadoop-datajoin in the patch passed.
+1 💚 unit 3m 32s hadoop-aws in the patch passed.
+1 💚 asflicense 1m 30s The patch does not generate ASF License warnings.
969m 5s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/2/artifact/out/Dockerfile
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 79f53412dbea 5.15.0-101-generic #111-Ubuntu SMP Tue Mar 5 20:16:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1767c00
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/2/testReport/
Max. process+thread count 4253 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 2s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 56 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 50s Maven dependency ordering for branch
+1 💚 mvninstall 31m 53s trunk passed
+1 💚 compile 16m 57s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 15m 36s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 checkstyle 4m 55s trunk passed
+1 💚 mvnsite 18m 52s trunk passed
+1 💚 javadoc 16m 31s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 16m 28s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 29m 55s trunk passed
+1 💚 shadedclient 33m 37s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
+1 💚 mvninstall 11m 15s the patch passed
+1 💚 compile 16m 34s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 16m 34s the patch passed
+1 💚 compile 15m 37s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 javac 15m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 4m 43s /results-checkstyle-root.txt root: The patch generated 3 new + 3956 unchanged - 6 fixed = 3959 total (was 3962)
+1 💚 mvnsite 18m 52s the patch passed
+1 💚 javadoc 16m 37s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 16m 29s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 34m 21s the patch passed
+1 💚 shadedclient 34m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 19s hadoop-common in the patch passed.
+1 💚 unit 3m 48s hadoop-kms in the patch passed.
-1 ❌ unit 227m 46s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 1m 20s hadoop-yarn-api in the patch passed.
+1 💚 unit 5m 59s hadoop-yarn-common in the patch passed.
+1 💚 unit 3m 55s hadoop-yarn-server-common in the patch passed.
+1 💚 unit 105m 42s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 24m 59s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 28m 44s hadoop-yarn-client in the patch passed.
+1 💚 unit 7m 47s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 1m 37s hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 9m 9s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 4m 35s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 unit 126m 53s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 unit 24m 24s hadoop-distcp in the patch passed.
+1 💚 unit 1m 4s hadoop-yarn-server-router in the patch passed.
+1 💚 unit 1m 25s hadoop-mapreduce-examples in the patch passed.
+1 💚 unit 7m 25s hadoop-streaming in the patch passed.
+1 💚 unit 1m 6s hadoop-rumen in the patch passed.
+1 💚 unit 1m 8s hadoop-datajoin in the patch passed.
+1 💚 unit 3m 25s hadoop-aws in the patch passed.
+1 💚 asflicense 1m 24s The patch does not generate ASF License warnings.
993m 30s
Reason Tests
Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline
hadoop.hdfs.server.datanode.TestLargeBlockReport
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/4/artifact/out/Dockerfile
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 40ec55848a19 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ebc0bd9
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/4/testReport/
Max. process+thread count 3744 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 2s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 56 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 20s Maven dependency ordering for branch
+1 💚 mvninstall 32m 9s trunk passed
+1 💚 compile 17m 26s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 16m 30s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 checkstyle 4m 48s trunk passed
+1 💚 mvnsite 20m 4s trunk passed
+1 💚 javadoc 17m 42s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 17m 37s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 31m 4s trunk passed
+1 💚 shadedclient 34m 24s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 35s Maven dependency ordering for patch
+1 💚 mvninstall 11m 45s the patch passed
+1 💚 compile 16m 58s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 16m 58s the patch passed
+1 💚 compile 16m 19s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 javac 16m 19s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 4m 54s /results-checkstyle-root.txt root: The patch generated 7 new + 3898 unchanged - 62 fixed = 3905 total (was 3960)
+1 💚 mvnsite 20m 11s the patch passed
+1 💚 javadoc 17m 44s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 17m 38s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 35m 42s the patch passed
+1 💚 shadedclient 34m 29s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 38s hadoop-common in the patch passed.
+1 💚 unit 3m 54s hadoop-kms in the patch passed.
+1 💚 unit 229m 0s hadoop-hdfs in the patch passed.
+1 💚 unit 1m 27s hadoop-yarn-api in the patch passed.
+1 💚 unit 6m 7s hadoop-yarn-common in the patch passed.
+1 💚 unit 4m 1s hadoop-yarn-server-common in the patch passed.
+1 💚 unit 106m 1s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 24m 46s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 28m 51s hadoop-yarn-client in the patch passed.
+1 💚 unit 7m 51s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 1m 41s hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 9m 6s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 4m 40s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 unit 127m 45s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 unit 24m 55s hadoop-distcp in the patch passed.
+1 💚 unit 1m 19s hadoop-yarn-server-router in the patch passed.
+1 💚 unit 1m 34s hadoop-mapreduce-examples in the patch passed.
+1 💚 unit 7m 32s hadoop-streaming in the patch passed.
+1 💚 unit 1m 10s hadoop-rumen in the patch passed.
+1 💚 unit 1m 16s hadoop-datajoin in the patch passed.
+1 💚 unit 3m 35s hadoop-aws in the patch passed.
+1 💚 asflicense 1m 31s The patch does not generate ASF License warnings.
1012m 25s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/5/artifact/out/Dockerfile
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 1ae0aa4485bb 5.15.0-101-generic #111-Ubuntu SMP Tue Mar 5 20:16:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 5a0cf37
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/5/testReport/
Max. process+thread count 3929 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see some usage of StringBuffer in the code, is that intentional? We just want to replace in couple of places?
image

@pjfanning
Copy link
Contributor Author

pjfanning commented Aug 16, 2024 •
edited
Loading

I still see some usage of StringBuffer in the code, is that intentional? We just want to replace in couple of places? image

I didn't focus too much on the test code because I wanted to keep the size of the PR down. There are also a few places where StringBuffer is required by the APIs that are used. For example, if an existing public method returns a StringBuffer, I didn't change the code for backward compatibility reasons.

@pjfanning pjfanning force-pushed the HADOOP-19134-stringbuilder branch from 5a0cf37 to 0054b5d Compare August 16, 2024 20:20
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 3s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 56 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 46s Maven dependency ordering for branch
+1 💚 mvninstall 32m 23s trunk passed
+1 💚 compile 17m 27s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 16m 13s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 4m 44s trunk passed
+1 💚 mvnsite 20m 27s trunk passed
+1 💚 javadoc 18m 6s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 17m 53s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 31m 26s trunk passed
+1 💚 shadedclient 34m 56s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
+1 💚 mvninstall 12m 12s the patch passed
+1 💚 compile 17m 14s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 17m 14s the patch passed
+1 💚 compile 16m 22s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 16m 22s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 5m 2s /results-checkstyle-root.txt root: The patch generated 8 new + 3898 unchanged - 62 fixed = 3906 total (was 3960)
+1 💚 mvnsite 20m 29s the patch passed
+1 💚 javadoc 18m 3s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 17m 46s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 35m 56s the patch passed
+1 💚 shadedclient 34m 53s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 36s hadoop-common in the patch passed.
+1 💚 unit 3m 54s hadoop-kms in the patch passed.
+1 💚 unit 223m 51s hadoop-hdfs in the patch passed.
+1 💚 unit 1m 27s hadoop-yarn-api in the patch passed.
+1 💚 unit 6m 3s hadoop-yarn-common in the patch passed.
+1 💚 unit 4m 0s hadoop-yarn-server-common in the patch passed.
+1 💚 unit 105m 50s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 25m 7s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 28m 46s hadoop-yarn-client in the patch passed.
+1 💚 unit 8m 36s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 1m 41s hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 9m 9s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 4m 39s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 unit 127m 26s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 unit 25m 21s hadoop-distcp in the patch passed.
+1 💚 unit 1m 8s hadoop-yarn-server-router in the patch passed.
+1 💚 unit 1m 31s hadoop-mapreduce-examples in the patch passed.
+1 💚 unit 7m 31s hadoop-streaming in the patch passed.
+1 💚 unit 1m 13s hadoop-rumen in the patch passed.
+1 💚 unit 1m 16s hadoop-datajoin in the patch passed.
+1 💚 unit 3m 21s hadoop-aws in the patch passed.
+1 💚 asflicense 1m 31s The patch does not generate ASF License warnings.
1009m 40s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/6/artifact/out/Dockerfile
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 80adac4e4c6d 5.15.0-113-generic #123-Ubuntu SMP Mon Jun 10 08:16:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0054b5d
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/6/testReport/
Max. process+thread count 4458 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/6/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning
Copy link
Contributor Author

The tests are passing in the CI build but I am getting issues due to formatting checks. Some of the files are already incorrectly formatted. In this commit, I reformatted a whole file to try to silence the CI warnings but this is now the biggest part of the PR diff.

bf731f8

@ayushtkn
Copy link
Member

If they are pre existing issues we need not to fix here, if needed we can track it separately else we can live with them…

ayushtkn
ayushtkn approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, there is one change just for checkstyle fix, maybe that can be avoided in this scope

...-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestTextOutputFormat.java Outdated Show resolved Hide resolved
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 3s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 56 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 20s Maven dependency ordering for branch
+1 💚 mvninstall 32m 22s trunk passed
+1 💚 compile 17m 31s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 16m 5s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 4m 45s trunk passed
+1 💚 mvnsite 20m 22s trunk passed
+1 💚 javadoc 18m 3s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 17m 56s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 31m 20s trunk passed
+1 💚 shadedclient 34m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
+1 💚 mvninstall 12m 1s the patch passed
+1 💚 compile 16m 53s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 16m 53s the patch passed
+1 💚 compile 16m 19s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 16m 19s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 4m 38s /results-checkstyle-root.txt root: The patch generated 24 new + 3606 unchanged - 354 fixed = 3630 total (was 3960)
+1 💚 mvnsite 20m 27s the patch passed
+1 💚 javadoc 18m 4s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 17m 56s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 35m 53s the patch passed
+1 💚 shadedclient 34m 51s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 41s hadoop-common in the patch passed.
+1 💚 unit 3m 53s hadoop-kms in the patch passed.
+1 💚 unit 221m 27s hadoop-hdfs in the patch passed.
+1 💚 unit 1m 30s hadoop-yarn-api in the patch passed.
+1 💚 unit 6m 9s hadoop-yarn-common in the patch passed.
+1 💚 unit 4m 12s hadoop-yarn-server-common in the patch passed.
+1 💚 unit 105m 39s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 25m 15s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 28m 45s hadoop-yarn-client in the patch passed.
+1 💚 unit 8m 48s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 1m 43s hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 9m 10s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 4m 42s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 unit 127m 53s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 unit 25m 1s hadoop-distcp in the patch passed.
+1 💚 unit 1m 8s hadoop-yarn-server-router in the patch passed.
+1 💚 unit 1m 32s hadoop-mapreduce-examples in the patch passed.
+1 💚 unit 7m 32s hadoop-streaming in the patch passed.
+1 💚 unit 1m 12s hadoop-rumen in the patch passed.
+1 💚 unit 1m 17s hadoop-datajoin in the patch passed.
+1 💚 unit 3m 24s hadoop-aws in the patch passed.
+1 💚 asflicense 1m 33s The patch does not generate ASF License warnings.
1005m 23s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/7/artifact/out/Dockerfile
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux d931b26c75be 5.15.0-113-generic #123-Ubuntu SMP Mon Jun 10 08:16:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / bf731f8
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/7/testReport/
Max. process+thread count 4468 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/7/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 11m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 2s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 56 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 13s Maven dependency ordering for branch
+1 💚 mvninstall 31m 55s trunk passed
+1 💚 compile 16m 19s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 14m 55s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 4m 8s trunk passed
+1 💚 mvnsite 17m 6s trunk passed
+1 💚 javadoc 14m 55s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 14m 51s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 27m 42s trunk passed
+1 💚 shadedclient 34m 1s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for patch
+1 💚 mvninstall 10m 26s the patch passed
+1 💚 compile 15m 48s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 15m 48s the patch passed
+1 💚 compile 14m 56s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 14m 56s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 4m 1s /results-checkstyle-root.txt root: The patch generated 2 new + 3896 unchanged - 66 fixed = 3898 total (was 3962)
+1 💚 mvnsite 17m 7s the patch passed
+1 💚 javadoc 14m 46s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 14m 51s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 32m 16s the patch passed
+1 💚 shadedclient 33m 49s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 1s hadoop-common in the patch passed.
+1 💚 unit 3m 39s hadoop-kms in the patch passed.
+1 💚 unit 218m 53s hadoop-hdfs in the patch passed.
+1 💚 unit 1m 20s hadoop-yarn-api in the patch passed.
+1 💚 unit 5m 47s hadoop-yarn-common in the patch passed.
+1 💚 unit 3m 48s hadoop-yarn-server-common in the patch passed.
+1 💚 unit 103m 22s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 24m 29s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 28m 14s hadoop-yarn-client in the patch passed.
+1 💚 unit 8m 15s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 1m 29s hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 8m 47s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 4m 21s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 unit 124m 57s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 unit 22m 1s hadoop-distcp in the patch passed.
+1 💚 unit 0m 55s hadoop-yarn-server-router in the patch passed.
+1 💚 unit 1m 18s hadoop-mapreduce-examples in the patch passed.
+1 💚 unit 7m 10s hadoop-streaming in the patch passed.
+1 💚 unit 0m 57s hadoop-rumen in the patch passed.
+1 💚 unit 1m 3s hadoop-datajoin in the patch passed.
+1 💚 unit 3m 4s hadoop-aws in the patch passed.
+1 💚 asflicense 1m 16s The patch does not generate ASF License warnings.
961m 26s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/8/artifact/out/Dockerfile
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 1d17b58d662e 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1b6c7bc
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/8/testReport/
Max. process+thread count 3878 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/8/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 56 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 13m 47s Maven dependency ordering for branch
+1 💚 mvninstall 19m 51s trunk passed
+1 💚 compile 9m 0s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 8m 17s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 2m 25s trunk passed
+1 💚 mvnsite 12m 57s trunk passed
+1 💚 javadoc 11m 39s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 11m 54s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 19m 4s trunk passed
+1 💚 shadedclient 20m 48s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 42s Maven dependency ordering for patch
+1 💚 mvninstall 7m 32s the patch passed
+1 💚 compile 8m 46s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 8m 46s the patch passed
+1 💚 compile 8m 17s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 8m 17s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 2m 24s /results-checkstyle-root.txt root: The patch generated 2 new + 3956 unchanged - 5 fixed = 3958 total (was 3961)
+1 💚 mvnsite 12m 40s the patch passed
+1 💚 javadoc 10m 18s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 11m 38s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 22m 18s the patch passed
+1 💚 shadedclient 20m 45s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 16m 56s hadoop-common in the patch passed.
+1 💚 unit 3m 15s hadoop-kms in the patch passed.
-1 ❌ unit 192m 31s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 0m 56s hadoop-yarn-api in the patch passed.
+1 💚 unit 4m 49s hadoop-yarn-common in the patch passed.
+1 💚 unit 3m 2s hadoop-yarn-server-common in the patch passed.
+1 💚 unit 90m 11s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 22m 3s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 25m 36s hadoop-yarn-client in the patch passed.
+1 💚 unit 6m 36s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 1m 11s hadoop-mapreduce-client-common in the patch passed.
+1 💚 unit 7m 5s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 3m 22s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 unit 111m 14s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 unit 24m 47s hadoop-distcp in the patch passed.
+1 💚 unit 0m 40s hadoop-yarn-server-router in the patch passed.
+1 💚 unit 1m 2s hadoop-mapreduce-examples in the patch passed.
+1 💚 unit 6m 3s hadoop-streaming in the patch passed.
+1 💚 unit 0m 44s hadoop-rumen in the patch passed.
+1 💚 unit 0m 51s hadoop-datajoin in the patch passed.
+1 💚 unit 2m 26s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 55s The patch does not generate ASF License warnings.
773m 57s
Reason Tests
Failed junit tests hadoop.hdfs.util.TestCombinedHostsFileReader
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/9/artifact/out/Dockerfile
GITHUB PR #6692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux b304ccf54928 5.15.0-116-generic #126-Ubuntu SMP Mon Jul 1 10:14:24 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / fe3efc6
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/9/testReport/
Max. process+thread count 4708 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/9/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning
Copy link
Contributor Author

I've run TestCombinedHostsFileReader a few times locally and it seems fairly flaky. Passes most of the time but some tests fail occassionally.

@ayushtkn
Copy link
Member

ayushtkn commented Aug 18, 2024 •
edited
Loading

I tried locally the failing test without this PR and it isn't passing for me even once, so, it is unrelated merging!!!

Checkstyle warning flagged were already present, not introduced by this PR

@ayushtkn ayushtkn merged commit 59dba6e into apache:trunk Aug 18, 2024
2 of 5 checks passed
KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Sep 9, 2024
@pjfanning @KeeProMise
HADOOP-19134. Use StringBuilder instead of StringBuffer. (apache#6692)…
a0cb2fa 
…. Contributed by PJ Fanning
Hexiaoqiao pushed a commit to Hexiaoqiao/hadoop that referenced this pull request Sep 12, 2024
@pjfanning @Hexiaoqiao
HADOOP-19134. Use StringBuilder instead of StringBuffer. (apache#6692)…
306b65c 
…. Contributed by PJ Fanning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees
No one assigned
Labels
AWS Common DistCp HDFS MapReduce TOOLS trunk YARN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjfanning @hadoop-yetus @ayushtkn