Skip to content

HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. #6664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slfan1989 merged 4 commits into from
Apr 27, 2024
Merged

HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. #6664

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
997cf56
HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5.
slfan1989 Mar 24, 2024
68cebe0
HADOOP-19071. Fix CheckStyle.
slfan1989 Mar 27, 2024
5a625b2
HADOOP-19071. Add Default Property.
slfan1989 Apr 4, 2024
488e15e
HADOOP-19071. Add Default Property.
slfan1989 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dev-support/bin/hadoop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,7 @@ function shadedclient_rebuild
extra=(
"-Dtest=NoUnitTests"
"-Dmaven.javadoc.skip=true"
"-Dsurefire.failIfNoSpecifiedTests=false"
"-Dcheckstyle.skip=true"
"-Dspotbugs.skip=true"
)
Expand Down Expand Up @@ -614,7 +615,7 @@ function shadedclient_rebuild
echo_and_redirect "${logfile}" \
"${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae --batch-mode -am \
"${modules[@]}" \
-DskipShade -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \
-DskipShade -Dsurefire.failIfNoSpecifiedTests=false -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \

@slfan1989 slfan1989 Mar 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I carefully readed the build report, and -Dsurefire.failIfNoSpecifiedTests=false is necessary because we have some modules without JUnit tests. We use -Dtest=NoUnitTests to handle this, which can cause an error.

@steveloughran steveloughran Apr 3, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just make this the default in our pom definitions? I disable tests all the time to run failsafe ITests in the integration phase only.

-Dspotbugs.skip=true ${extra[*]}

count=$("${GREP}" -c '\[ERROR\]' "${logfile}")
Expand Down
2 changes: 1 addition & 1 deletion hadoop-project/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@

<!-- Plugin versions and config -->
<maven-surefire-plugin.argLine>-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError</maven-surefire-plugin.argLine>
<maven-surefire-plugin.version>3.0.0-M1</maven-surefire-plugin.version>
<maven-surefire-plugin.version>3.2.5</maven-surefire-plugin.version>
<maven-surefire-report-plugin.version>${maven-surefire-plugin.version}</maven-surefire-report-plugin.version>
<maven-failsafe-plugin.version>${maven-surefire-plugin.version}</maven-failsafe-plugin.version>

Expand Down