HDDS-1357. ozone s3 shell command has confusing subcommands #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted by Elek, Marton.
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
LGTM, once Jenkins reported issues are fixed. |
Contributor
|
+1 with checkstyle and 1 NIT addressed. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
+1 LGTM. I will commit this shortly. |
asfgit
pushed a commit
that referenced
this pull request
Mar 30, 2019
(cherry picked from commit ec82e4c)
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
<img width="400" alt="deployment-model-doc" src="https://user-images.githubusercontent.com/37879374/46053365-59274100-c0f7-11e8-9e43-a1d7612b9330.png"> Author: Cameron Lee <[email protected]> Reviewers: Jagadish<[email protected]> Closes apache#663 from cameronlee314/deployment_model_doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's check the potential subcommands of ozone sh:
{code}
[hadoop@om-0 keytabs]$ ozone sh
Incomplete command
Usage: ozone sh [-hV] [--verbose] [-D=<String=String>]... [COMMAND]
Shell for Ozone object store
--verbose More verbose output. Show the stack trace of the errors.
-D, --set=<String=String>
-h, --help Show this help message and exit.
-V, --version Print version information and exit.
Commands:
volume, vol Volume specific operations
bucket Bucket specific operations
key Key specific operations
token Token specific operations
{code}
This is fine, but for ozone s3:
{code}
[hadoop@om-0 keytabs]$ ozone s3
Incomplete command
Usage: ozone s3 [-hV] [--verbose] [-D=<String=String>]... [COMMAND]
Shell for S3 specific operations
--verbose More verbose output. Show the stack trace of the errors.
-D, --set=<String=String>
-h, --help Show this help message and exit.
-V, --version Print version information and exit.
Commands:
getsecret Returns s3 secret for current user
path Returns the ozone path for S3Bucket
volume, vol Volume specific operations
bucket Bucket specific operations
key Key specific operations
token Token specific operations
{code}
This list should contain only the getsecret/path commands and not the volume/bucket/key subcommands.
See: https://issues.apache.org/jira/browse/HDDS-1357