HDFS-17397. Choose another DN as soon as possible, when encountering network issues #6591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
hi, @ZanderXu please take a review, thanks |
|
💔 -1 overall
This message was automatically generated. |
ZanderXu
reviewed
Feb 29, 2024
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
cc @Hexiaoqiao please take a review, thanks |
Member
Author
|
cc @steveloughran PTAL |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
I don't go near HDFS code; HDFS dev team are happy about this. sorry. |
Member
Author
OK |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
@xleoken Thanks for your proposal. I am not sure this is the proper solution for your case as @ZanderXu mentioned. IIUC, you expect to fast fail when meet network issue between client and the first DataNode while write data to pipeline, right? IMO, it is difficult to determine to do that because, For this case, we have discussed times, I think we need to split it to two step, report metrics back to client, then improve strategy (fast fail or switch dn or some other way based on different metrics). FYI. |
Member
Author
|
@Hexiaoqiao thanks for your review, you're right, I'll think about it again. |
Member
Author
|
@Hexiaoqiao I tried to learn more about the 1、Write 2、Default block size: 128MB, packet size: 64KB, Add debug log, DataStreamer -> ResponseProcessor 3、Simulate error exception 4、 |
|
💔 -1 overall
This message was automatically generated. |
Member
Author
Contributor
|
@xleoken Thanks for your works and patch. However I don't think it is the graceful solution or improvement as mentioned above. Thanks again. |
|
This patch works for my case, lgtm. |
|
Thanks!
…On Thu, Mar 28, 2024 at 4:17 PM Apache Hadoop Yetus Account < ***@***.***> wrote:
💔 *-1 overall*
Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author <https://github.com/author> 0m 0s The patch does not
contain any @author <https://github.com/author> tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 44m 30s trunk passed
+1 💚 compile 1m 1s trunk passed with JDK
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 0m 57s trunk passed with JDK Private
Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 checkstyle 0m 34s trunk passed
+1 💚 mvnsite 0m 59s trunk passed
+1 💚 javadoc 0m 50s trunk passed with JDK
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 0m 44s trunk passed with JDK Private
Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
-1 ❌ spotbugs 2m 38s
/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
<https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6591/12/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html> hadoop-hdfs-project/hadoop-hdfs-client
in trunk has 1 extant spotbugs warnings.
+1 💚 shadedclient 34m 49s branch has no errors when building and testing
our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 49s the patch passed
+1 💚 compile 0m 53s the patch passed with JDK
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 0m 53s the patch passed
+1 💚 compile 0m 45s the patch passed with JDK Private
Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 javac 0m 45s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 21s the patch passed
+1 💚 mvnsite 0m 47s the patch passed
+1 💚 javadoc 0m 36s the patch passed with JDK
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 0m 35s the patch passed with JDK Private
Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 2m 34s the patch passed
+1 💚 shadedclient 34m 38s patch has no errors when building and testing
our client artifacts.
_ Other Tests _
+1 💚 unit 2m 25s hadoop-hdfs-client in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
135m 1s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6591/12/artifact/out/Dockerfile
GITHUB PR #6591 <#6591>
Optional Tests dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 8e980caff1e4 5.15.0-94-generic #104
<#104>-Ubuntu SMP Tue Jan 9 15:25:40
UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 73d6c12
<73d6c12>
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6591/12/testReport/
Max. process+thread count 552 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client U:
hadoop-hdfs-project/hadoop-hdfs-client
Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6591/12/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org
This message was automatically generated.
—
Reply to this email directly, view it on GitHub
<#6591 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGHNPXUIDEMCB2NKM337C2TY2PGYJAVCNFSM6AAAAABDZ3KKAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUG4ZTGOJWGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
lgtm |
|
💔 -1 overall
This message was automatically generated. |
|
LGTM |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
When there is a network issue between the client and DN, the write process will enter hang state. We hope to choose another DN as soon as possible when encountering network problems.
How was this patch tested?
Local tested.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?