You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to HDFS-17374.
We met a strange and serious problem on the one of product cluster using EC.
The problem can be reproduced every time when writing mass data into this EC cluster along with the network card is full. After writing, there are many half-open connection and can never release by themselves until we restart datanode.
After digging into some logs and codes, we suspect that it was caused by StripedBlockReader#newConnectedPeer without setting tcp_keepalive.
This problem is very serious, because it can use up datanode‘s available port.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
41m 38s
trunk passed
+1 💚
compile
1m 19s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
compile
1m 11s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
checkstyle
1m 9s
trunk passed
+1 💚
mvnsite
1m 18s
trunk passed
+1 💚
javadoc
1m 5s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
1m 35s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
spotbugs
3m 14s
trunk passed
+1 💚
shadedclient
34m 20s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
1m 7s
the patch passed
+1 💚
compile
1m 11s
the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javac
1m 11s
the patch passed
+1 💚
compile
1m 5s
the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
javac
1m 5s
the patch passed
+1 💚
blanks
0m 0s
The patch has no blanks issues.
+1 💚
checkstyle
0m 57s
the patch passed
+1 💚
mvnsite
1m 9s
the patch passed
+1 💚
javadoc
0m 52s
the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
1m 28s
the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
spotbugs
3m 16s
the patch passed
+1 💚
shadedclient
34m 40s
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
44m 27s
trunk passed
+1 💚
compile
1m 22s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
compile
1m 18s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
checkstyle
1m 11s
trunk passed
+1 💚
mvnsite
1m 23s
trunk passed
+1 💚
javadoc
1m 5s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
1m 31s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
spotbugs
3m 13s
trunk passed
+1 💚
shadedclient
35m 45s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
1m 15s
the patch passed
+1 💚
compile
1m 13s
the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javac
1m 13s
the patch passed
+1 💚
compile
1m 13s
the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
javac
1m 13s
the patch passed
+1 💚
blanks
0m 0s
The patch has no blanks issues.
+1 💚
checkstyle
1m 2s
the patch passed
+1 💚
mvnsite
1m 13s
the patch passed
+1 💚
javadoc
0m 51s
the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
1m 28s
the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
spotbugs
3m 16s
the patch passed
+1 💚
shadedclient
36m 37s
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
43m 15s
trunk passed
+1 💚
compile
1m 18s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
compile
1m 13s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
checkstyle
1m 6s
trunk passed
+1 💚
mvnsite
1m 20s
trunk passed
+1 💚
javadoc
1m 2s
trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
1m 31s
trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
spotbugs
3m 19s
trunk passed
+1 💚
shadedclient
35m 37s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
1m 9s
the patch passed
+1 💚
compile
1m 9s
the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javac
1m 9s
the patch passed
+1 💚
compile
1m 6s
the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
javac
1m 6s
the patch passed
+1 💚
blanks
0m 0s
The patch has no blanks issues.
+1 💚
checkstyle
1m 3s
the patch passed
+1 💚
mvnsite
1m 15s
the patch passed
+1 💚
javadoc
0m 51s
the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚
javadoc
1m 28s
the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚
spotbugs
3m 30s
the patch passed
+1 💚
shadedclient
36m 20s
patch has no errors when building and testing our client artifacts.
@tasanuma Hi, sir. Thanks for your reviewing. Now i can not conclude whether it solve this problem on our cluster due to Spring Festival‘s low peak of throughput. Please allow me to reply you a few days later~ Thanks a lot sir.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
93m 48s
trunk passed
+1 💚
compile
6m 30s
trunk passed
+1 💚
checkstyle
5m 09s
trunk passed
+1 💚
mvnsite
7m 06s
trunk passed
+1 💚
javadoc
6m 30s
trunk passed
+1 💚
shadedclient
154m 24s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
4m 59s
the patch passed
+1 💚
compile
3m 42s
the patch passed
+1 💚
javac
3m 42s
the patch passed
+1 💚
blanks
0m 00s
The patch has no blanks issues.
+1 💚
checkstyle
2m 34s
the patch passed
+1 💚
mvnsite
4m 43s
the patch passed
+1 💚
javadoc
3m 47s
the patch passed
+1 💚
shadedclient
167m 33s
patch has no errors when building and testing our client artifacts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Refer to HDFS-17374.
We met a strange and serious problem on the one of product cluster using EC.
The problem can be reproduced every time when writing mass data into this EC cluster along with the network card is full. After writing, there are many half-open connection and can never release by themselves until we restart datanode.
After digging into some logs and codes, we suspect that it was caused by StripedBlockReader#newConnectedPeer without setting tcp_keepalive.
This problem is very serious, because it can use up datanode‘s available port.