Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-19058. [JDK-17] Fix UT Failures in hadoop common, hdfs, yarn #6531

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

HADOOP-19058. [JDK-17] Fix UT Failures in hadoop common, hdfs, yarn #6531

wants to merge 1 commit into from
+12 −1

Conversation

BilwaST
Copy link
Contributor

@BilwaST BilwaST commented Feb 6, 2024

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 41m 54s trunk passed
+1 💚 compile 0m 21s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 21s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 mvnsite 0m 26s trunk passed
+1 💚 javadoc 0m 27s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 23s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 shadedclient 75m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 14s the patch passed
+1 💚 compile 0m 13s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 13s the patch passed
+1 💚 compile 0m 13s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 javac 0m 13s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 16s the patch passed
+1 💚 javadoc 0m 14s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 14s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 shadedclient 33m 7s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 17s hadoop-project in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
115m 27s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6531/1/artifact/out/Dockerfile
GITHUB PR #6531
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux b47656071f4b 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / fcb51d7
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6531/1/testReport/
Max. process+thread count 672 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6531/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989
slfan1989 reviewed Feb 6, 2024
View reviewed changes
hadoop-project/pom.xml
@@ -168,7 +168,18 @@
<enforced.maven.version>[3.3.0,)</enforced.maven.version>

<!-- Plugin versions and config -->
<maven-surefire-plugin.argLine>-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError</maven-surefire-plugin.argLine>
<maven-surefire-plugin.argLine>-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for submitting this PR. We are looking forward to Hadoop supporting JDK11 and JDK17.

I have some questions:

Should we fully support JDK11 and JDK17, or should we try to avoid certain issues by adding some compilation parameters?

From my perspective, we should find ways to upgrade the code and make all modules fully compatible with the recommended syntax of JDK11 and JDK17.

@aajisaka @ayushtkn @steveloughran

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a big ongoing bit of work; aws have been busier than the rest of us...we do test against later java versions, but do the build/UT/IT against v8.

I'd like to move 3.5 and then 3.4.x to java17+ ..., where x is a release which comes out this year but is greater than 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway, regarding this line: the exports thing is java11+ only, right? so it should only be set on java11+.

proposed: add a java17 profile and set some maven.surefire.java17.options string to it there, on the default java8 profile set it to ""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spark added such JVM args unconditional with -XX:+IgnoreUnrecognizedVMOptions, this might be a simpler way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HBase uses maven profiles for these options, and it works well.

@steveloughran
Copy link
Contributor

commented. I looked at surefire and it is at 3.2.5; probably time to upgrade. I propose it is done before doing this one, splitting them in two.

and we need java8 and java17 profiles so we can add other options in other places

@slfan1989
Copy link
Contributor

commented. I looked at surefire and it is at 3.2.5; probably time to upgrade. I propose it is done before doing this one, splitting them in two.

and we need java8 and java17 profiles so we can add other options in other places

I agree with your points, but there are some additional details to be added:

  • I agree to establish profiles for Java 8 and Java 17, and I think we should also include Java 11 and Java 21.
  • There are still some pending tasks related to Java 11. We need to continue working on HADOOP-15984, specifically updating Jersey from version 1.19 to 2.x. Ideally, we should update it to Jersey 3.x. （I will start following this JIRA in the next 1-2 days）
  • We need to migrate from JUnit 4 to JUnit 5. Some progress has already been made in Yarn.
  • We should consider upgrading the version of the Maven Surefire Plugin. Currently, we are using 3.0.0-M1, but I suggest upgrading it to 3.2.2. I have noticed that some projects are using this version, and I will try it out.

I will create a JIRA ticket for Java 17 compile support. I am aware that there is a lot of work to be done, and I hope that we can address the JDK support issue this year.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 00s No case conflicting files found.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+0 🆗 xmllint 0m 01s xmllint was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 00s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 92m 58s trunk passed
+1 💚 compile 4m 29s trunk passed
+1 💚 mvnsite 4m 34s trunk passed
+1 💚 javadoc 4m 33s trunk passed
+1 💚 shadedclient 246m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 01s the patch passed
+1 💚 compile 1m 55s the patch passed
+1 💚 javac 1m 55s the patch passed
+1 💚 blanks 0m 00s The patch has no blanks issues.
+1 💚 mvnsite 1m 59s the patch passed
+1 💚 javadoc 1m 57s the patch passed
+1 💚 shadedclient 152m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 5m 29s The patch does not generate ASF License warnings.
418m 45s
Subsystem Report/Notes
GITHUB PR #6531
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname MINGW64_NT-10.0-17763 fef11fae28ac 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / fcb51d7
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6531/1/testReport/
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6531/1/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran
steveloughran reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, realised I hadn't submitted by review. here it is though we've already discussed the issues

hadoop-project/pom.xml
@@ -168,7 +168,18 @@
<enforced.maven.version>[3.3.0,)</enforced.maven.version>

<!-- Plugin versions and config -->
<maven-surefire-plugin.argLine>-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError</maven-surefire-plugin.argLine>
<maven-surefire-plugin.argLine>-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway, regarding this line: the exports thing is java11+ only, right? so it should only be set on java11+.

proposed: add a java17 profile and set some maven.surefire.java17.options string to it there, on the default java8 profile set it to ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slfan1989 slfan1989 slfan1989 left review comments

@pan3793 pan3793 pan3793 left review comments

@stoty stoty stoty left review comments

@steveloughran steveloughran steveloughran left review comments

Assignees
No one assigned
Labels
build trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BilwaST @hadoop-yetus @steveloughran @slfan1989 @stoty @pan3793