HADOOP-16118. S3Guard to support on-demand DDB tables. #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds awareness of on-demand tables; it does not support creating them as a new SDK upgrade is needed for that. This patch is one which can be backported without the consequences of such an update. * The diagnostics map includes the billing mode (as inferred from IO capacities) * Set capacity fails fast (and always). * The documentation discusses the mode, argues for it over autoscaling * Example output of bucket-info updated * Test that if the table is on-demand, set-capacity will fail. * If table is on-demand, The dynamo db scale tests are disabled. There's nothing to prove. Change-Id: I77b7a6b593a2cd805376ca24d68b06bde75589c5
Contributor
Author
|
Tested: S3a ireland with s3guard _ dynamoDB. One failure, which I am not sure if/how it is related to on-demand tables. |
| bills when it is not. | ||
|
|
||
| Before DynamoDB On-Demand was introduced, autoscaling was the sole form | ||
| of dynamic scaling. |
|
💔 -1 overall
This message was automatically generated. |
noslowerdna
reviewed
Mar 27, 2019
| retry counts and an interval which allow for the clients to cope with | ||
| some throttling, but not to time out other applications. | ||
| This is why the DynamoDB On-Demand appears to be a better option for | ||
| workloads with Hadoop, Spark, Hive and othe rapplications. |
Contributor
There was a problem hiding this comment.
typo, "other applications"
noslowerdna
reviewed
Mar 27, 2019
| workloads with Hadoop, Spark, Hive and othe rapplications. | ||
|
|
||
| If autoscaling is to be used, we recommend experimenting with the option, | ||
| based on usage information collected from previous days, and and choosing a |
steveloughran
added
the
fs/s3
This was referenced Mar 28, 2019
Closed
| bills when it is not. | ||
|
|
||
| Before DynamoDB On-Demand was introduced, autoscaling was the sole form | ||
| of dynamic scaling. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
merged into trunk; #731 covers the backport |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
This Request is a copy of apache#647(got garbled). This PR already addresses all the comments brought up in the other request. Author: Boris S <[email protected]> Author: Boris S <[email protected]> Author: Boris Shkolnik <[email protected]> Reviewers: Shanthoosh Venkatraman <[email protected]>, Prateek Maheshwari <[email protected]> Closes apache#662 from sborya/NewConsumerAdmin2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds awareness of on-demand tables; it does not support
creating them as a new SDK upgrade is needed for that. This patch
is one which can be backported without the consequences of such an update.
Change-Id: I77b7a6b593a2cd805376ca24d68b06bde75589c5