-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Preparing for 3.5.0 development #6411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing for 3.5.0 development #6411
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
Spotbugs Report shows 2 Spotbugs:
|
@slfan1989 The second warning has been fixed: https://issues.apache.org/jira/browse/HDFS-17315 |
@huangzhaobo99 Thanks for helping fix this issue! |
|
💔 -1 overall
This message was automatically generated. |
|
@slfan1989 Hi Shilun, We should check in this PR first then branch-3.4 could freeze and point branch-3.5.0 to trunk for devs. What do you think about? Thanks. |
|
Mark this PR to 'ready to review' and re-trigger CI mannually. |
|
💔 -1 overall
This message was automatically generated. |
|
The lastest CI report only contain spotbugs which is fixed by #6419 and had checkin. IMO it is ready to merge. cc @slfan1989 @ayushtkn Any more concerns? Thanks. |
Hexiaoqiao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1.
@Hexiaoqiao Thanks for reviewing the code! I will trigger the compilation again. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
2f16d3b to
af60724
Compare
|
💔 -1 overall
This message was automatically generated. |
|
@Hexiaoqiao This is a flaky test and is unrelated to the version change. The spotbug issue has already been resolved. This flaky test has been tried to be fixed(#6459), and I will continue to follow up on it. |
|
Great! Committed to trunk. Thanks @slfan1989 |
Co-authored-by: slfan1989 <[email protected]>
Description of PR
We plan to release hadoop-3.4.0 and are making preparations. We need to change the trunk branch to 3.5.0-SNAPSHOT.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?