HDDS-1255. Refactor ozone acceptance test to allow run in secure mode. Contributed by Ajay Kumar. #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
+1, pending nightly run results. |
elek
requested changes
Mar 23, 2019
Member
There was a problem hiding this comment.
What is the goal of this file? Based on the name it's not clear for me.
Member
There was a problem hiding this comment.
Oh, I got it. I think you assume it's always executed before all the tests. I would use a generic test initialization file:
http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#initialization-files
and a 'Suite Setup'. Kinit can be executed in case of the SECURITY_ENABLED is set. An other init file can be added to the s3 directory to initialize the s3 credentials.
Member
There was a problem hiding this comment.
Not clear why these keywords are moved to the commonlib. Is there any reason for that?
Contributor
Author
There was a problem hiding this comment.
This can be used inside security robot tests as well.
Member
There was a problem hiding this comment.
Do we need to install aws cli for all the tests? I think most of the time "Kinit test user" is enough
Contributor
Author
There was a problem hiding this comment.
currently it used to setup aws secure credentials.
Contributor
Author
There was a problem hiding this comment.
you are right, moved s3 part to s3 commonlib.
Member
There was a problem hiding this comment.
NIT: can be more clean to use two different test case:
- Create volume bucket with wrong credentials
- Create volume bucket
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
Mar 26, 2019
Contributor
There was a problem hiding this comment.
shall we move this to commonawslib.robot?
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
Mar 27, 2019
Contributor
There was a problem hiding this comment.
dup line 18 can be removed.
|
💔 -1 overall
This message was automatically generated. |
Member
|
I am trying to test it but it's still failing. For example: |
Member
|
I also noticed a lot of security related exceptions: |
Contributor
|
You need to configure the service level authorization in hadoop-policy.xml when hadoop.security.authorization is true. Try setting hadoop.security.authorization = false to see if you can get the authentication part verified first. Then add individual rules in hadoop-policy.xml with hadoop.security.authorization=true. |
…. Contributed by Ajay Kumar.
|
💔 -1 overall
This message was automatically generated. |
| Library String | ||
| Library BuiltIn | ||
|
|
||
| *** Variables *** |
| ${output} = Execute aws s3api --endpoint-url ${ENDPOINT_URL} list-buckets | ||
| Should contain ${output} bucket-test123 | ||
|
|
||
| Secure S3 test Failure |
| if [ "${COMPOSE_DIR}" == "ozonesecure" ]; then | ||
| SECURITY_ENABLED="true" | ||
| else | ||
| SECURITY_ENABLED="false" |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
elek
approved these changes
Mar 29, 2019
| Library String | ||
| Library BuiltIn | ||
|
|
||
| *** Variables *** |
| ${output} = Execute aws s3api --endpoint-url ${ENDPOINT_URL} list-buckets | ||
| Should contain ${output} bucket-test123 | ||
|
|
||
| Secure S3 test Failure |
| SECURITY_ENABLED="true" | ||
| else | ||
| SECURITY_ENABLED="false" | ||
| fi |
|
💔 -1 overall
This message was automatically generated. |
Member
|
Thanks the update @ajayydv. +1 if jenkins is passed... |
|
💔 -1 overall
This message was automatically generated. |
elek
pushed a commit
that referenced
this pull request
Apr 1, 2019
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…ests. Author: Shanthoosh Venkataraman <[email protected]> Author: Shanthoosh Venkataraman <[email protected]> Reviewers: Jagadish<[email protected]>, Boris Shkolnik<[email protected]> Closes apache#632 from shanthoosh/fix_zk_crap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.