YARN-11595. Fix hadoop-yarn-client#java.lang.NoClassDefFoundError #6210

slfan1989 · 2023-10-20T14:39:27Z

Description of PR

JIRA: YARN-11595. Fix hadoop-yarn-client#java.lang.NoClassDefFoundError.

When completing the PR, I found the following issue in the compilation report:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test (default-test) on project hadoop-yarn-client: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test failed: java.lang.NoClassDefFoundError: org/junit/jupiter/api/TestInfo: org.junit.jupiter.api.TestInfo

I encountered this issue in both YARN-11593. [Federation] Improve command line help information. (#6199) and YARN-11592. Add timeout to GPGUtils#invokeRMWebService. (#6189)

The test report is as follows:

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6199/9/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2023-10-20T16:30:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 54s		trunk passed
+1 💚	compile	0m 28s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 26s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	mvnsite	0m 30s		trunk passed
+1 💚	javadoc	0m 32s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 25s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	shadedclient	56m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 20s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 20s		the patch passed
+1 💚	compile	0m 19s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 20s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	shadedclient	21m 51s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	26m 0s		hadoop-yarn-client in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		109m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6210/1/artifact/out/Dockerfile
GITHUB PR	#6210
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux 7a08d2fa6748 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d585b74`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6210/1/testReport/
Max. process+thread count	700 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6210/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn

Does it fail in the daily build as well?

slfan1989 · 2023-10-21T03:42:12Z

Does it fail in the daily build as well?

@ayushtkn Thank you very much for your help in reviewing the code! I will check the daily build.

hadoop-yetus · 2023-10-21T16:21:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 24s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 50s		trunk passed
+1 💚	compile	0m 26s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 26s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	mvnsite	0m 31s		trunk passed
+1 💚	javadoc	0m 32s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 25s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	shadedclient	59m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s		the patch passed
+1 💚	compile	0m 18s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 18s		the patch passed
+1 💚	compile	0m 17s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 17s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 18s		the patch passed
+1 💚	javadoc	0m 17s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 17s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	shadedclient	25m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	26m 1s		hadoop-yarn-client in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		116m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6210/1/artifact/out/Dockerfile
GITHUB PR	#6210
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux 948a36dadd9a 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d585b74`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6210/1/testReport/
Max. process+thread count	579 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6210/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2023-10-22T11:10:17Z

@ayushtkn I checked the daily build of yarn_hadoop-yarn-client and the same error was reported.

Sat 21 Oct 2023 01:59:57 PM UTC
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/1386/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt

Fri 20 Oct 2023 01:51:33 PM UTC
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/1385/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt

ayushtkn · 2023-10-22T13:59:37Z

Thanx for the confirmation, feel free to merge

slfan1989 · 2023-10-22T14:22:57Z

@ayushtkn Thank you very much for your help in reviewing the code!

…ache#6210) Contributed by Shilun Fan. Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Shilun Fan <[email protected]>

YARN-11595. Fix hadoop-yarn-client#java.lang.NoClassDefFoundError

d585b74

github-actions bot added YARN build trunk labels Oct 20, 2023

ayushtkn approved these changes Oct 20, 2023

View reviewed changes

slfan1989 merged commit d7d772d into apache:trunk Oct 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-11595. Fix hadoop-yarn-client#java.lang.NoClassDefFoundError #6210

YARN-11595. Fix hadoop-yarn-client#java.lang.NoClassDefFoundError #6210

Uh oh!

slfan1989 commented Oct 20, 2023 •

edited

Loading

Uh oh!

hadoop-yetus commented Oct 20, 2023

Uh oh!

ayushtkn left a comment

Uh oh!

slfan1989 commented Oct 21, 2023

Uh oh!

hadoop-yetus commented Oct 21, 2023

Uh oh!

slfan1989 commented Oct 22, 2023

Uh oh!

ayushtkn commented Oct 22, 2023

Uh oh!

slfan1989 commented Oct 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YARN-11595. Fix hadoop-yarn-client#java.lang.NoClassDefFoundError #6210

YARN-11595. Fix hadoop-yarn-client#java.lang.NoClassDefFoundError #6210

Uh oh!

Conversation

slfan1989 commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Oct 20, 2023

Uh oh!

ayushtkn left a comment

Choose a reason for hiding this comment

Uh oh!

slfan1989 commented Oct 21, 2023

Uh oh!

hadoop-yetus commented Oct 21, 2023

Uh oh!

slfan1989 commented Oct 22, 2023

Uh oh!

ayushtkn commented Oct 22, 2023

Uh oh!

slfan1989 commented Oct 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

slfan1989 commented Oct 20, 2023 •

edited

Loading