-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11577. Improve FederationInterceptorREST Method Result. #6190
Conversation
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
...-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java
Show resolved
Hide resolved
...ter/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java
Show resolved
Hide resolved
...ter/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java
Show resolved
Hide resolved
...rver-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterWebServices.java
Show resolved
Hide resolved
...rver-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterWebServices.java
Show resolved
Hide resolved
@goiri Can you help review this PR? Thank you very much! I added comments to the code. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@goiri Can you help review this PR? Thank you very much! I added comments to the code. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@goiri Can you help review this PR? Thank you very much! I've added some comments to the code. There are 3 purposes for this PR
|
@goiri Can you help review this PR? Thank you very much! |
assertNotNull(nodesInfo); | ||
ArrayList<NodeInfo> nodes = nodesInfo.getNodes(); | ||
assertNotNull(nodes); | ||
return (0 == nodes.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isEmpty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion! I will improve it.
assertNotNull(nodesInfo); | ||
ArrayList<NodeInfo> nodes = nodesInfo.getNodes(); | ||
assertNotNull(nodes); | ||
return (0 == nodes.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isEmpty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will improve it.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@goiri Thank you very much for your help reviewing the code! |
…6190) Contributed by Shilun Fan. Reviewed-by: Inigo Goiri <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Description of PR
JIRA: YARN-11577. Improve FederationInterceptorREST Method Result.
We expect that Router's REST methods remain consistent with RM under boundary conditions, such as when no elements are returned.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?