-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-17204. EC: Reduce unnecessary log when processing excess redundancy. #6107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
LGTM. |
Hexiaoqiao
approved these changes
Sep 25, 2023
Contributor
Hexiaoqiao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1.
Contributor
|
Committed to trunk. Thanks @zhangshuyan0 for your contribution and @haiyang1987 for your reviews! |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…ncy. (apache#6107). Contributed by Shuyan Zhang. Reviewed-by: Haiyang Hu <haiyang.hu@shopee.com> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
LiuGuH
pushed a commit
to LiuGuH/hadoop
that referenced
this pull request
Jan 6, 2026
…ncy. (apache#6107). Contributed by Shuyan Zhang. Reviewed-by: Haiyang Hu <haiyang.hu@shopee.com> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
This is a follow-up of HDFS-16964. We now avoid stale replicas when dealing with redundancy. This may result in redundant replicas not being in the
nonExcessset when we enterBlockManager#chooseExcessRedundancyStriped(because the datanode where the redundant replicas are located has not send FBR yet, so those replicas are filtered out and not added to thenonExcessset). A further result is that no excess storage type is selected and the log "excess types chosen for block..." is printed. When a failover occurs, a large number of datanodes become stale, which causes NameNodes to print a large number of unnecessary logs.This issue needs to be fixed, otherwise the performance after failover will be affected.