HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao. #594

xiaoyuyao · 2019-03-12T14:00:51Z

No description provided.

ajayydv · 2019-03-13T23:04:55Z

hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java

Shall we replace "Cannot get ozone delegation token from" with "Cannot get ozone delegation token for {}, renewer"?

will fix in the next push.

hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java

hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OMFailoverProxyProvider.java

ajayydv · 2019-03-14T03:19:48Z

...zone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSelector.java

shall we dial it down to debug level?

Yes, I will definitely change this to DEBUG.

ajayydv · 2019-03-14T03:21:19Z

hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto

it is already optional.

Agree, this PR was created before that change. This will be fixed in next push after rebase.

hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/O3fsDtFetcher.java

…ontributed by Xiaoyu Yao.

hadoop-yetus · 2019-03-14T18:37:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	24	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	69	Maven dependency ordering for branch
+1	mvninstall	1099	trunk passed
+1	compile	102	trunk passed
+1	checkstyle	32	trunk passed
+1	mvnsite	106	trunk passed
+1	shadedclient	738	branch has no errors when building and testing our client artifacts.
+1	findbugs	137	trunk passed
+1	javadoc	85	trunk passed
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
+1	mvninstall	93	the patch passed
+1	compile	90	the patch passed
+1	javac	90	the patch passed
+1	checkstyle	24	the patch passed
+1	mvnsite	83	the patch passed
+1	shellcheck	25	There were no new shellcheck issues.
+1	shelldocs	17	There were no new shelldocs issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	810	patch has no errors when building and testing our client artifacts.
+1	findbugs	154	the patch passed
+1	javadoc	77	the patch passed
		_ Other Tests _
+1	unit	38	common in the patch passed.
+1	unit	28	client in the patch passed.
+1	unit	91	ozonefs in the patch passed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		4122

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-594/1/artifact/out/Dockerfile
GITHUB PR	#594
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle shellcheck shelldocs
uname	Linux 3e369e125c30 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `d60673c`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
shellcheck	v0.4.6
findbugs	v3.1.0-RC1
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-594/1/testReport/
Max. process+thread count	2982 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozonefs U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-594/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-15T04:35:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	21	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	30	Maven dependency ordering for branch
+1	mvninstall	1280	trunk passed
+1	compile	108	trunk passed
+1	checkstyle	30	trunk passed
+1	mvnsite	110	trunk passed
+1	shadedclient	731	branch has no errors when building and testing our client artifacts.
+1	findbugs	150	trunk passed
+1	javadoc	85	trunk passed
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
+1	mvninstall	92	the patch passed
+1	compile	93	the patch passed
+1	javac	93	the patch passed
+1	checkstyle	25	the patch passed
+1	mvnsite	82	the patch passed
+1	shellcheck	27	There were no new shellcheck issues.
+1	shelldocs	14	There were no new shelldocs issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	816	patch has no errors when building and testing our client artifacts.
+1	findbugs	155	the patch passed
+1	javadoc	77	the patch passed
		_ Other Tests _
+1	unit	37	common in the patch passed.
+1	unit	28	client in the patch passed.
+1	unit	94	ozonefs in the patch passed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		4284

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-594/2/artifact/out/Dockerfile
GITHUB PR	#594
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle shellcheck shelldocs
uname	Linux 9e0430b6eea6 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `2627dad`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
shellcheck	v0.4.6
findbugs	v3.1.0-RC1
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-594/2/testReport/
Max. process+thread count	2913 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozonefs U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-594/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…ontributed by Xiaoyu Yao. (#594) (cherry picked from commit 5cfb88a)

- Fixed serde issues during persisted offsets locally - Added unit tests for TaskSideInputStorageManager - Added integration tests for table integration Author: bharathkk <[email protected]> Author: Bharath Kumarasubramanian <[email protected]> Reviewers: Prateek Maheshwari <[email protected]> Closes apache#594 from bharathkk/side-input-tests

xiaoyuyao self-assigned this Mar 12, 2019

xiaoyuyao added the ozone label Mar 12, 2019

ajayydv reviewed Mar 13, 2019

View reviewed changes

ajayydv reviewed Mar 14, 2019

View reviewed changes

hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java Outdated Show resolved Hide resolved

ajayydv reviewed Mar 14, 2019

View reviewed changes

hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OMFailoverProxyProvider.java Outdated Show resolved Hide resolved

ajayydv reviewed Mar 14, 2019

View reviewed changes

hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/O3fsDtFetcher.java Outdated Show resolved Hide resolved

xiaoyuyao added 2 commits March 14, 2019 09:58

HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. C…

1371f1e

…ontributed by Xiaoyu Yao.

Change ozone token selector log to debug level.

5cbe33d

xiaoyuyao force-pushed the HDDS-1246 branch from 3435788 to 5cbe33d Compare March 14, 2019 17:27

Address pr feedback on log usage.

c1e16f6

ajayydv merged commit 5cfb88a into apache:trunk Mar 15, 2019

asfgit pushed a commit that referenced this pull request Mar 21, 2019

HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. C…

b2c63c3

…ontributed by Xiaoyu Yao. (#594) (cherry picked from commit 5cfb88a)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao. #594

HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao. #594

Uh oh!

xiaoyuyao commented Mar 12, 2019

Uh oh!

ajayydv Mar 13, 2019

Uh oh!

xiaoyuyao Mar 14, 2019

Uh oh!

Uh oh!

Uh oh!

ajayydv Mar 14, 2019

Uh oh!

xiaoyuyao Mar 14, 2019

Uh oh!

ajayydv Mar 14, 2019

Uh oh!

xiaoyuyao Mar 14, 2019

Uh oh!

Uh oh!

hadoop-yetus commented Mar 14, 2019

Uh oh!

hadoop-yetus commented Mar 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao. #594

HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao. #594

Uh oh!

Conversation

xiaoyuyao commented Mar 12, 2019

Uh oh!

ajayydv Mar 13, 2019

Choose a reason for hiding this comment

Uh oh!

xiaoyuyao Mar 14, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ajayydv Mar 14, 2019

Choose a reason for hiding this comment

Uh oh!

xiaoyuyao Mar 14, 2019

Choose a reason for hiding this comment

Uh oh!

ajayydv Mar 14, 2019

Choose a reason for hiding this comment

Uh oh!

xiaoyuyao Mar 14, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hadoop-yetus commented Mar 14, 2019

Uh oh!

hadoop-yetus commented Mar 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants