Skip to content

HDDS-1253 #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ajayydv merged 1 commit into from
Mar 12, 2019
Merged

HDDS-1253 #593

ajayydv merged 1 commit into from
Mar 12, 2019

Conversation

@xiaoyuyao
Copy link
Contributor

@xiaoyuyao xiaoyuyao commented Mar 12, 2019

No description provided.

@xiaoyuyao xiaoyuyao requested a review from ajayydv March 12, 2019 12:44
@xiaoyuyao xiaoyuyao self-assigned this Mar 12, 2019
@hadoop-yetus
Copy link

hadoop-yetus commented Mar 12, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 25 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 75 Maven dependency ordering for branch
+1 mvninstall 1039 trunk passed
+1 compile 936 trunk passed
+1 checkstyle 192 trunk passed
-1 mvnsite 54 client in trunk failed.
+1 shadedclient 1030 branch has no errors when building and testing our client artifacts.
-1 findbugs 35 client in trunk failed.
+1 javadoc 85 trunk passed
_ Patch Compile Tests _
0 mvndep 24 Maven dependency ordering for patch
-1 mvninstall 16 client in the patch failed.
+1 compile 889 the patch passed
+1 javac 889 the patch passed
+1 checkstyle 184 the patch passed
-1 mvnsite 36 client in the patch failed.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 679 patch has no errors when building and testing our client artifacts.
-1 findbugs 35 client in the patch failed.
+1 javadoc 84 the patch passed
_ Other Tests _
-1 unit 87 common in the patch failed.
-1 unit 35 client in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
5876
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/artifact/out/Dockerfile
GITHUB PR #593
JIRA Issue HDDS-1253
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 56f53673d418 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d17e31e
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/artifact/out/branch-mvnsite-hadoop-ozone_client.txt
findbugs v3.1.0-RC1
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/artifact/out/branch-findbugs-hadoop-ozone_client.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/artifact/out/patch-mvninstall-hadoop-ozone_client.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/artifact/out/patch-mvnsite-hadoop-ozone_client.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/artifact/out/patch-findbugs-hadoop-ozone_client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/artifact/out/patch-unit-hadoop-hdds_common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/artifact/out/patch-unit-hadoop-ozone_client.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-ozone/client U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-593/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@ajayydv
Copy link
Contributor

ajayydv commented Mar 12, 2019

@xiaoyuyao thanks for taking care of this. +1

@ajayydv ajayydv merged commit 2778259 into apache:trunk Mar 12, 2019
ajayydv pushed a commit that referenced this pull request Mar 12, 2019
@xiaoyuyao
HDDS-1253. Fix checkstyle issue from Nightly run. Contributed by Xiao…
262260f 
…yu Yao. (#593)

Closes PR #593

(cherry picked from commit 2778259)
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@pdu-mn1 @jagadish-v0
SAMZA-1763: Add async methods to Table API
a08040d 
Currently, Table API only has blocking/sync methods which limit the
throughput of remote tables. This change adds async methods to the API
to enable high throughput remote table accesses through usage of async
IO. The new methods are added to ReadableTable and ReadWriteTable. A
high level summary of the change is below:

- added async methods to table ReadableTable and ReadWriteTable.
- added async methods to TableRead/WriteFunction
- CompletableFuture is used for the async abstraction
- CachingTable are updated to support async methods
- added default impls for sync methods backed by async in table functions
- added helper class, Throttler/AsyncHelper to ease table development
- fixed existing test cases with table implementations
- added more thorough unit tests to RemoteTable CRUD methods

Additionally remove explicit check of config entries for remote table in
TestTableDescriptorsProvider since there is already a test case on
RemoteTableDescriptor.

Author: Peng Du <[email protected]>

Reviewers: Jagadish<[email protected]>, Wei <[email protected]>

Closes apache#593 from pdu-mn1/async-table-api-futures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajayydv ajayydv Awaiting requested review from ajayydv

Assignees

@xiaoyuyao xiaoyuyao

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiaoyuyao @hadoop-yetus @ajayydv