-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17088. Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md #5846
Conversation
🎊 +1 overall
This message was automatically generated. |
@haiyang1987 Thank you very much for your contribution! Whether the EC commands of HDFS are complete in the md document, can you help to check? If there is something missing, can we add it all in this pr. The main reason is to consider the convenience of other partners' backport code. |
Hi @slfan1989 sir thanks help me review . yeah, I will check whether the EC command of HDFS in the md document is complete. |
Hi @slfan1989 Sir, update EC command of HDFS in the md document. |
🎊 +1 overall
This message was automatically generated. |
@haiyang1987 LGTM, let's look at other partners' suggestions, if there is no comment after 2 days, it will be merged to the trunk branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dfsrouteradmin missed -dumpState
as well, we should add that as well
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java#L876
noted, i will update it later. |
Update PR, add -dumpState. @slfan1989 @goiri @ayushtkn sir please help me review this pr again when you have free time. Thanks a lot!!! |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@haiyang1987 Thanks for your contribution! @ayushtkn @goiri @tomscut Thanks for the review! |
Thanks @slfan1989 @ayushtkn @goiri @tomscut help me review and merge it. |
… HDFSCommands.md (apache#5846)
Description of PR
https://issues.apache.org/jira/browse/HDFS-17088
Improve the debug verifyEC and dfsrouteradmin commands in HDFSCommands.md
the debug verifyEC add new params description, such as [-blockId <blk_Id>] [-skipFailureBlocks].
dfsrouteradmin added a new command about -addAll.