Skip to content

Conversation

@ajayydv
Copy link
Contributor

@ajayydv ajayydv commented Mar 9, 2019

No description provided.

@ajayydv ajayydv requested a review from xiaoyuyao March 9, 2019 01:48
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 25 Docker mode activated.
_ Prechecks _
0 yamllint 0 yamllint was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 70 Maven dependency ordering for branch
+1 mvninstall 1090 trunk passed
+1 compile 951 trunk passed
+1 checkstyle 196 trunk passed
+1 mvnsite 144 trunk passed
+1 shadedclient 711 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/dist
+1 findbugs 75 trunk passed
+1 javadoc 75 trunk passed
_ Patch Compile Tests _
0 mvndep 26 Maven dependency ordering for patch
-1 mvninstall 18 dist in the patch failed.
+1 compile 879 the patch passed
+1 javac 879 the patch passed
+1 checkstyle 190 the patch passed
+1 mvnsite 84 the patch passed
+1 shellcheck 0 There were no new shellcheck issues.
+1 shelldocs 36 There were no new shelldocs issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 662 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/dist
+1 findbugs 83 the patch passed
+1 javadoc 81 the patch passed
_ Other Tests _
+1 unit 77 common in the patch passed.
+1 unit 35 dist in the patch passed.
+1 asflicense 44 The patch does not generate ASF License warnings.
5870
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-581/1/artifact/out/Dockerfile
GITHUB PR #581
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle yamllint shellcheck shelldocs
uname Linux dcfa55066c86 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c072458
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
shellcheck v0.4.6
findbugs v3.1.0-RC1
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-581/1/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-581/1/testReport/
Max. process+thread count 445 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-ozone/dist U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-581/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Just a few minor comments inline

@xiaoyuyao xiaoyuyao merged commit 599e926 into apache:trunk Mar 11, 2019
asfgit pushed a commit that referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants