Skip to content

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented May 28, 2023

What changes were proposed in this pull request?

Backport HADOOP-18433 (#4838) to branch-3.3.

@adoroszlai adoroszlai self-assigned this May 28, 2023
@adoroszlai adoroszlai added the backport Backport PR; reviews may be optional depending on nature of backport label May 28, 2023
@adoroszlai adoroszlai changed the base branch from trunk to branch-3.3 May 28, 2023 13:58
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 10m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 39m 19s branch-3.3 passed
+1 💚 compile 18m 42s branch-3.3 passed
+1 💚 checkstyle 0m 53s branch-3.3 passed
+1 💚 mvnsite 1m 33s branch-3.3 passed
+1 💚 javadoc 0m 46s branch-3.3 passed
+1 💚 spotbugs 2m 41s branch-3.3 passed
+1 💚 shadedclient 27m 8s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 57s the patch passed
+1 💚 compile 18m 1s the patch passed
+1 💚 javac 18m 1s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 46s the patch passed
+1 💚 mvnsite 1m 30s the patch passed
+1 💚 javadoc 0m 38s the patch passed
+1 💚 spotbugs 2m 36s the patch passed
+1 💚 shadedclient 27m 23s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 17m 22s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 asflicense 0m 51s The patch does not generate ASF License warnings.
171m 54s
Reason Tests
Failed junit tests hadoop.security.TestRaceWhenRelogin
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5692/1/artifact/out/Dockerfile
GITHUB PR #5692
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 26c1fa356522 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 2781f76
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5692/1/testReport/
Max. process+thread count 2696 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5692/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@adoroszlai adoroszlai requested a review from ZanderXu June 2, 2023 06:58
Copy link
Contributor

@ZanderXu ZanderXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for your work. LGTM

@adoroszlai adoroszlai merged commit 60b37bb into apache:branch-3.3 Jun 5, 2023
@adoroszlai adoroszlai deleted the HADOOP-18433_branch-3.3 branch June 5, 2023 05:51
@adoroszlai
Copy link
Contributor Author

Thanks @ZanderXu for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backport PR; reviews may be optional depending on nature of backport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants