HADOOP-18740. S3A prefetch cache blocks should be accessed by RW locks #5675

virajjasani · 2023-05-19T00:30:54Z

virajjasani · 2023-05-19T00:32:29Z

us-west-2

mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch

[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   ITestS3ABlockOutputArray.testDiskBlockCreate:114 » IO File name too long
[ERROR]   ITestS3ABlockOutputByteBuffer>ITestS3ABlockOutputArray.testDiskBlockCreate:114 » IO
[ERROR]   ITestS3ABlockOutputDisk>ITestS3ABlockOutputArray.testDiskBlockCreate:114 » IO ...
[ERROR]   ITestS3AFileContextMainOperations>FileContextMainOperationsBaseTest.testCreateFlagCreateAppendNonExistingFile:831 » IO
[ERROR]   ITestS3AFileContextURI>FileContextURIBase.testCreateFileInNonExistingDirectory:164 » IO
[ERROR]   ITestS3AFileContextURI>FileContextURIBase.testDeleteNonExistingFileInDir:357 » IO
[INFO] 
[ERROR] Tests run: 1165, Failures: 0, Errors: 6, Skipped: 148

All failures related to HADOOP-18744

hadoop-yetus · 2023-05-19T03:40:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 41s		trunk passed
+1 💚	compile	17m 33s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	15m 42s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 29s		trunk passed
+1 💚	javadoc	1m 10s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 41s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	2m 38s		trunk passed
+1 💚	shadedclient	25m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 51s		the patch passed
+1 💚	compile	16m 42s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	16m 42s		the patch passed
+1 💚	compile	15m 41s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	15m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 1s		the patch passed
+1 💚	mvnsite	1m 28s		the patch passed
+1 💚	javadoc	1m 0s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 41s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	2m 35s		the patch passed
+1 💚	shadedclient	25m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 19s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 54s		The patch does not generate ASF License warnings.
		187m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/1/artifact/out/Dockerfile
GITHUB PR	#5675
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ab2194f686fd 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `912403c`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/1/testReport/
Max. process+thread count	1235 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

MayankSinghParmar · 2023-05-30T19:30:39Z

I want to implement a new cache replacement algorithm in hdfs but I don't know which part of module to use and modify. Can any one please help me find the modules and functions which need to override to add my own caching replacement algorithm in hdfs

steveloughran · 2023-05-31T14:21:08Z

@MayankSinghParmar get on the hadoop hdfs mailing list and discuss there.

@virajjasani can you rebase and retest?

steveloughran

core changes look good, just a nit about using this. where it isn't needed.

I'm worried about concurrency of close(), where

we should make the closed flag atomic boolean; only execute close on the first call and have all the other ops fail if closed
be confident that locking in close() is good. After the disaster with the abfs prefetcher, we need to look carefully here

steveloughran · 2023-05-31T14:27:23Z

.../hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java

+     */
+    void takeLock(LockType lockType) {
+      if (LockType.READ == lockType) {
+        this.lock.readLock().lock();


remove the this.

steveloughran · 2023-05-31T14:27:50Z

.../hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java

+     */
+    void releaseLock(LockType lockType) {
+      if (LockType.READ == lockType) {
+        this.lock.readLock().unlock();


remove the this.

steveloughran · 2023-05-31T14:31:05Z

.../hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java

    int numFilesDeleted = 0;

    for (Entry entry : blocks.values()) {
+      entry.takeLock(Entry.LockType.WRITE);


should we be acquiring locks in close()?
good: no race condition in close
bad) the usual

also, L303: should closed be atomic?

also, L303: should closed be atomic?

+1 to this suggestion, let me create a separate patch with HADOOP-18756 to better track it.

good: no race condition in close
bad) the usual

sounds reasonable, let me try setting timeout

virajjasani · 2023-06-01T04:33:00Z

us-west-2:

mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale

mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch

Test results are clean

hadoop-yetus · 2023-06-01T05:07:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 1s		trunk passed
+1 💚	compile	15m 37s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	14m 21s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	1m 13s		trunk passed
+1 💚	mvnsite	1m 35s		trunk passed
+1 💚	javadoc	1m 17s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 52s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	2m 41s		trunk passed
+1 💚	shadedclient	22m 8s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 49s		the patch passed
+1 💚	compile	14m 52s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	14m 52s		the patch passed
+1 💚	compile	14m 19s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	14m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 6s		the patch passed
+1 💚	mvnsite	1m 33s		the patch passed
+1 💚	javadoc	1m 5s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 51s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	2m 34s		the patch passed
+1 💚	shadedclient	22m 23s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 32s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 2s		The patch does not generate ASF License warnings.
		174m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/2/artifact/out/Dockerfile
GITHUB PR	#5675
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 9432f0056538 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `710441f`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/2/testReport/
Max. process+thread count	1783 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran · 2023-06-01T11:55:55Z

.../hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java


    for (Entry entry : blocks.values()) {
-      entry.takeLock(Entry.LockType.WRITE);
+      boolean lockAcquired = entry.takeLock(Entry.LockType.WRITE, 5, TimeUnit.SECONDS);


pull the number into a constant. Know that I automatically -1 all inline constants in production code and save time all round.

my bad, let me fix this real quick

steveloughran · 2023-06-01T11:56:59Z

.../hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java

+     * @param unit the time unit of the timeout argument.
+     * @return true if the lock of the given lock type was acquired.
+     */
+    boolean takeLock(LockType lockType, long timeout, TimeUnit unit) {


should this and the others be private? you don't want other classes playing with your lock code...

sounds good, done

hadoop-yetus · 2023-06-01T18:43:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	37m 27s		trunk passed
+1 💚	compile	17m 27s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	15m 47s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 30s		trunk passed
+1 💚	javadoc	1m 9s		trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 42s		trunk passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	2m 42s		trunk passed
+1 💚	shadedclient	25m 22s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 51s		the patch passed
+1 💚	compile	16m 42s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	16m 42s		the patch passed
+1 💚	compile	15m 45s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	15m 45s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 0s		the patch passed
+1 💚	mvnsite	1m 31s		the patch passed
+1 💚	javadoc	1m 0s		the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	0m 42s		the patch passed with JDK Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	2m 33s		the patch passed
+1 💚	shadedclient	24m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 22s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 53s		The patch does not generate ASF License warnings.
		189m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/3/artifact/out/Dockerfile
GITHUB PR	#5675
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ce03b807e480 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d2b9210`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/3/testReport/
Max. process+thread count	1244 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran

+1. concurrency stuff always worries me, but this looks good

#5675) Contributed by Viraj Jasani

HADOOP-18740. S3A prefetch cache blocks should be accessed by RW locks

912403c

steveloughran requested changes May 31, 2023

View reviewed changes

virajjasani added 2 commits May 31, 2023 18:34

Merge branch 'trunk' of github.com:apache/hadoop into HADOOP-18740-trunk

33d64a4

addendum

710441f

steveloughran requested changes Jun 1, 2023

View reviewed changes

addendum

d2b9210

virajjasani mentioned this pull request Jun 5, 2023

HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag #5718

Merged

steveloughran approved these changes Jun 7, 2023

View reviewed changes

steveloughran merged commit 1dbaba8 into apache:trunk Jun 7, 2023

asfgit pushed a commit that referenced this pull request Jun 8, 2023

HADOOP-18740. S3A prefetch cache blocks should be accessed by RW locks (

afb863a

#5675) Contributed by Viraj Jasani

HADOOP-18740. S3A prefetch cache blocks should be accessed by RW locks #5675

HADOOP-18740. S3A prefetch cache blocks should be accessed by RW locks #5675

Uh oh!

Conversation

virajjasani commented May 19, 2023

Uh oh!

virajjasani commented May 19, 2023

Uh oh!

hadoop-yetus commented May 19, 2023

Uh oh!

MayankSinghParmar commented May 30, 2023

Uh oh!

steveloughran commented May 31, 2023

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Jun 1, 2023

Uh oh!

hadoop-yetus commented Jun 1, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jun 1, 2023

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants