HDDS-1043. Enable token based authentication for S3 api. #561
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -185,5 +185,6 @@ public enum ResultCodes { | |
|
|
||
| INVALID_KMS_PROVIDER, | ||
|
|
||
| TOKEN_CREATION_ERROR | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.ozone.security; | ||
|
|
||
| import org.apache.hadoop.util.StringUtils; | ||
| import org.apache.kerby.util.Hex; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import javax.crypto.Mac; | ||
| import javax.crypto.spec.SecretKeySpec; | ||
| import java.io.UnsupportedEncodingException; | ||
| import java.net.URLDecoder; | ||
| import java.nio.charset.Charset; | ||
| import java.nio.charset.StandardCharsets; | ||
| import java.security.GeneralSecurityException; | ||
| import java.security.MessageDigest; | ||
| import java.security.NoSuchAlgorithmException; | ||
|
|
||
| /** | ||
| * AWS v4 authentication payload validator. For more details refer to AWS | ||
| * documentation https://docs.aws.amazon.com/general/latest/gr/ | ||
| * sigv4-create-canonical-request.html. | ||
| **/ | ||
| final class AWSV4AuthValidator { | ||
|
|
||
| private final static Logger LOG = | ||
| LoggerFactory.getLogger(AWSV4AuthValidator.class); | ||
| private static final String HMAC_SHA256_ALGORITHM = "HmacSHA256"; | ||
| private static final Charset UTF_8 = Charset.forName("utf-8"); | ||
|
|
||
| private AWSV4AuthValidator() { | ||
| } | ||
|
|
||
| private static String urlDecode(String str) { | ||
| try { | ||
| return URLDecoder.decode(str, UTF_8.name()); | ||
| } catch (UnsupportedEncodingException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| public static String hash(String payload) throws NoSuchAlgorithmException { | ||
| MessageDigest md = MessageDigest.getInstance("SHA-256"); | ||
| md.update(payload.getBytes(UTF_8)); | ||
| return String.format("%064x", new java.math.BigInteger(1, md.digest())); | ||
| } | ||
|
|
||
| private static byte[] sign(byte[] key, String msg) { | ||
| try { | ||
| SecretKeySpec signingKey = new SecretKeySpec(key, HMAC_SHA256_ALGORITHM); | ||
| Mac mac = Mac.getInstance(HMAC_SHA256_ALGORITHM); | ||
| mac.init(signingKey); | ||
| return mac.doFinal(msg.getBytes(StandardCharsets.UTF_8)); | ||
| } catch (GeneralSecurityException gse) { | ||
| throw new RuntimeException(gse); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Returns signing key. | ||
| * | ||
| * @param key | ||
| * @param strToSign | ||
| * | ||
| * SignatureKey = HMAC-SHA256(HMAC-SHA256(HMAC-SHA256(HMAC-SHA256("AWS4" + | ||
| * "<YourSecretAccessKey>","20130524"),"us-east-1"),"s3"),"aws4_request") | ||
| * | ||
| * For more details refer to AWS documentation: https://docs.aws.amazon | ||
| * .com/AmazonS3/latest/API/sig-v4-header-based-auth.html | ||
| * | ||
| * */ | ||
| private static byte[] getSigningKey(String key, String strToSign) { | ||
| String[] signData = StringUtils.split(StringUtils.split(strToSign, | ||
| '\n')[2], '/'); | ||
| String dateStamp = signData[0]; | ||
| String regionName = signData[1]; | ||
| String serviceName = signData[2]; | ||
| byte[] kDate = sign(("AWS4" + key).getBytes(UTF_8), dateStamp); | ||
| byte[] kRegion = sign(kDate, regionName); | ||
| byte[] kService = sign(kRegion, serviceName); | ||
| byte[] kSigning = sign(kService, "aws4_request"); | ||
| LOG.info(Hex.encode(kSigning)); | ||
| return kSigning; | ||
| } | ||
|
|
||
| /** | ||
| * Validate request by comparing Signature from request. Returns true if | ||
| * aws request is legit else returns false. | ||
| * Signature = HEX(HMAC_SHA256(key, String to Sign)) | ||
| * | ||
| * For more details refer to AWS documentation: https://docs.aws.amazon.com | ||
| * /AmazonS3/latest/API/sigv4-streaming.html | ||
| */ | ||
| public static boolean validateRequest(String strToSign, String signature, | ||
| String userKey) { | ||
| String expectedSignature = Hex.encode(sign(getSigningKey(userKey, | ||
| strToSign), strToSign)); | ||
| return expectedSignature.equals(signature); | ||
| } | ||
ajayydv marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two methods are confusing a little. Especially as the bigger part of the implementation is duplicated. Would be great to merge them (or use better naming). (Not a blocker, we can address it later).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed new api to getS3UserSecretString, open to any better name you may suggest. Purpose of both api's is different so consolidating them right not might not be a good option. We can discuss this further in separate jira.