Skip to content

HADOOP-18711 upgrade to nimbus jwt 9.31 #5573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ayushtkn merged 2 commits into from
Apr 22, 2023
Merged

HADOOP-18711 upgrade to nimbus jwt 9.31 #5573

ayushtkn merged 2 commits into from
Apr 22, 2023

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Apr 19, 2023

Description of PR

upgrade jar due to problematic embedded json-smart code

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

hadoop-yetus commented Apr 20, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 17m 20s Maven dependency ordering for branch
+1 💚 mvninstall 30m 41s trunk passed
+1 💚 compile 30m 10s trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 26m 9s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 mvnsite 29m 30s trunk passed
-1 ❌ javadoc 0m 21s /branch-javadoc-root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt root in trunk failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.
+1 💚 javadoc 8m 15s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
-1 ❌ shadedclient 30m 52s branch has errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 27m 23s the patch passed
+1 💚 compile 24m 37s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 24m 37s the patch passed
+1 💚 compile 21m 42s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 javac 21m 42s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 21m 18s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
-1 ❌ javadoc 8m 36s /results-javadoc-javadoc-root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 1387 new + 0 unchanged - 0 fixed = 1387 total (was 0)
+1 💚 javadoc 7m 29s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
-1 ❌ shadedclient 39m 37s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 4m 5s /patch-unit-root.txt root in the patch failed.
+0 🆗 asflicense 0m 30s ASF License check generated no output?
308m 51s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/1/artifact/out/Dockerfile
GITHUB PR #5573
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux c83f0d5870bd 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 27cded2
Default Java Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/1/testReport/
Max. process+thread count 190 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning pjfanning force-pushed the HADOOP-18711-nimbus branch from 27cded2 to 38c83e0 Compare April 20, 2023 08:38
@hadoop-yetus
Copy link

hadoop-yetus commented Apr 21, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 16m 18s Maven dependency ordering for branch
+1 💚 mvninstall 29m 2s trunk passed
+1 💚 compile 24m 55s trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 21m 36s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 mvnsite 28m 27s trunk passed
+1 💚 javadoc 9m 46s trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 7m 43s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 shadedclient 39m 50s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 25m 5s the patch passed
+1 💚 compile 24m 50s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 24m 50s the patch passed
+1 💚 compile 21m 47s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 javac 21m 47s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 21m 14s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 9m 0s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 8m 9s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 shadedclient 41m 17s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 764m 17s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 19s The patch does not generate ASF License warnings.
1064m 48s
Reason Tests
Failed junit tests hadoop.mapreduce.v2.TestUberAM
hadoop.mapreduce.v2.TestMRJobsWithProfiler
hadoop.mapreduce.v2.TestMRJobs
hadoop.hdfs.server.namenode.ha.TestObserverNode
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/2/artifact/out/Dockerfile
GITHUB PR #5573
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux e941edf969eb 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 38c83e0
Default Java Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/2/testReport/
Max. process+thread count 2622 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/2/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last set of test failures aren't related. If the rebase build comes clean then changes LGTM

@hadoop-yetus
Copy link

hadoop-yetus commented Apr 22, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 16m 14s Maven dependency ordering for branch
-1 ❌ mvninstall 16m 50s /branch-mvninstall-root.txt root in trunk failed.
+1 💚 compile 25m 11s trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 21m 39s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 mvnsite 26m 33s trunk passed
+1 💚 javadoc 8m 28s trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 7m 24s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 shadedclient 38m 25s branch has no errors when building and testing our client artifacts.
-0 ⚠️ patch 38m 42s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 mvninstall 25m 51s the patch passed
+1 💚 compile 24m 41s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 24m 41s the patch passed
+1 💚 compile 24m 53s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 javac 24m 53s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 22m 5s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 11s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 7m 29s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 shadedclient 38m 55s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 773m 55s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 25s The patch does not generate ASF License warnings.
1061m 33s
Reason Tests
Failed junit tests hadoop.mapreduce.v2.TestUberAM
hadoop.mapreduce.v2.TestMRJobsWithProfiler
hadoop.mapreduce.v2.TestMRJobs
hadoop.hdfs.TestRollingUpgrade
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/3/artifact/out/Dockerfile
GITHUB PR #5573
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux fa47985c98e5 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0a56c73
Default Java Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/3/testReport/
Max. process+thread count 2623 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/3/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn ayushtkn merged commit ad49ddd into apache:trunk Apr 22, 2023
@ayushtkn
Copy link
Member

ayushtkn commented Apr 22, 2023

Patch compile tests were green & the failing tests are failing in the daily builds as well. Merged!!!

rohit-kb pushed a commit to rohit-kb/hadoop that referenced this pull request May 10, 2023
@pjfanning @rohit-kb
HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded sh…
c18c24d 
…aded json-smart code. (apache#5573). Contributed by PJ Fanning.

Signed-off-by: Ayush Saxena <[email protected]>
rohit-kb pushed a commit to rohit-kb/hadoop that referenced this pull request Oct 18, 2023
@pjfanning @rohit-kb
HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded sh…
1cbf5b1 
…aded json-smart code. (apache#5573). Contributed by PJ Fanning.

Signed-off-by: Ayush Saxena <[email protected]>
@pjfanning pjfanning mentioned this pull request Oct 18, 2023
Closed
4 tasks
@pjfanning pjfanning deleted the HADOOP-18711-nimbus branch October 18, 2023 10:21
pjfanning added a commit to pjfanning/hadoop that referenced this pull request Oct 18, 2023
@pjfanning
HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded sh…
b32edb7 
…aded json-smart code. (apache#5573). Contributed by PJ Fanning.

Signed-off-by: Ayush Saxena <[email protected]>
pjfanning added a commit to pjfanning/hadoop that referenced this pull request Oct 18, 2023
@pjfanning
HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded sh…
3ca7f16 
…aded json-smart code. (apache#5573). Contributed by PJ Fanning.

Signed-off-by: Ayush Saxena <[email protected]>

Update LICENSE-binary
@pjfanning pjfanning mentioned this pull request Oct 18, 2023
Merged
4 tasks
pjfanning added a commit to pjfanning/hadoop that referenced this pull request Oct 23, 2023
@pjfanning
HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded sh…
c5117dd 
…aded json-smart code. (apache#5573). Contributed by PJ Fanning.

Signed-off-by: Ayush Saxena <[email protected]>

Update LICENSE-binary
ayushtkn pushed a commit that referenced this pull request Oct 27, 2023
@pjfanning
HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded sh…
61c7b55 
…aded json-smart code. (#5573). Contributed by PJ Fanning. (#6201)

Signed-off-by: Ayush Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pjfanning @hadoop-yetus @ayushtkn