-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11442. Refactor FederationInterceptorREST Code. #5420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a6ae2e4
YARN-11442. Refactor FederationInterceptorREST Code.
fee6edc
Merge branch 'apache:trunk' into YARN-11442
slfan1989 2679517
YARN-11442. Fix CheckStyle.
56c23d9
Merge branch 'apache:trunk' into YARN-11442
slfan1989 d4bff69
YARN-11442. Fix CheckStyle.
1b5182b
YARN-11442. Fix CheckStyle.
2e7c6f4
YARN-11442. Fix CheckStyle.
da4db6f
YARN-11442. Fix CheckStyle.
1e4267d
Merge branch 'apache:trunk' into YARN-11442
slfan1989 9bf5209
YARN-11442. Fix CheckStyle.
200ef75
YARN-11442. Fix CheckStyle.
989dc22
YARN-11442. Fix CheckStyle.
76f8dc2
YARN-11442. Fix CheckStyle.
ef0d026
YARN-11442. Fix CheckStyle.
1620923
YARN-11442. Fix CheckStyle.
870d0a5
YARN-11442. Fix CheckStyle.
4575c06
Merge branch 'apache:trunk' into YARN-11442
slfan1989 82aadb0
Merge branch 'trunk' into YARN-11442
slfan1989 2a31bd2
YARN-11442. Fix CheckStyle.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this still static?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the places where we call it to call it as static.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your help to review the code! This part of the code can continue to be static, I will modify the code.