HDDS-1193. Refactor ContainerChillModeRule and DatanodeChillMode rule. #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajayydv
reviewed
Mar 1, 2019
Contributor
There was a problem hiding this comment.
when maxContainer is 0 then (containerWithMinReplicas.get() / maxContainer) will throw exception.
Contributor
Author
There was a problem hiding this comment.
In validate(), we call getCurrentContainerThreshold(),
public double getCurrentContainerThreshold() {
if (maxContainer == 0) {
return 1;
}
return (containerWithMinReplicas.doubleValue() / maxContainer);
}
public boolean validate() {
return getCurrentContainerThreshold() >= chillModeCutoff;
}
So, if maxContainer=0, in validate() call, we get 1 from getCurrentContainerThreshold() and do >= check.
Contributor
There was a problem hiding this comment.
Before validation we should add new report data to threshold.
Contributor
Author
There was a problem hiding this comment.
This check is added, suppose this rule is already satisfied, I don't need to process it, so that is the reason for the first check.
Contributor
Author
There was a problem hiding this comment.
Updated the code with slight change.
Contributor
There was a problem hiding this comment.
We should process data from this report before validating again.
bharatviswa504
force-pushed
the
HDDS-1193
branch
from
c6f37a8 to
731eb26
Compare
Contributor
Author
|
Thank You @ajayydv for offline discussion. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
LGTM. +1 |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Samza currently depends on httpclient 4.5.2 and httpcore 4.4.5. However, httpclient 4.5.2 also has a direct dependency on httpcore 4.4.4, which is not backwards compatible with httpcore 4.4.5 since some classes were removed (e.g. ThreadSafe/NotThreadSafe annotation classes). Although this does not currently cause any direct build problems, there may be cases where this conflict introduces transitive dependency conflicts. In addition, this inconsistency can cause confusion in future development if those libraries need to be used. Author: Cameron Lee <[email protected]> Reviewers: Jagadish Venkatraman <[email protected]>, Shanthoosh Venkatraman <[email protected]> Closes apache#534 from cameronlee314/httpcore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.