-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11349. [Federation] Router Support DelegationToken With SQL. #5244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| import org.apache.hadoop.yarn.server.federation.store.records.RouterMasterKeyRequest; | ||
| import org.apache.hadoop.yarn.server.federation.store.records.RouterRMTokenRequest; | ||
| import org.apache.hadoop.yarn.server.federation.store.records.RouterStoreToken; | ||
| import org.apache.hadoop.yarn.server.federation.store.records.RouterMasterKeyRequest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid these changes in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion, I will modify the code.
| public Integer handle(Object... params) throws SQLException { | ||
| Integer result = 0; | ||
| for (Object param : params) { | ||
| if (param != null && param instanceof FederationSQLOutParameter) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to check null as instanceof already does it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@goiri Thank you very much for helping to review the code this year and learned a lot from you! Merry Christmas to you! |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
I will execute Federation SQL scripts in MySQL and SQLServer databases to ensure the accuracy of the scripts. MySQL SQLServer |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
SQL Server 2008 R2 Enterprise
SQL Server 2012 Enterprise
SQL Server 2014 Enterprise
SQL Server 2016 Enterprise
SQL Server 2017 Enterprise
SQL Server 2019 Enterprise
|
|
The failures are unrelated. |
Thank you very much for your help in reviewing the code! I will rebase this pr again, and then we can merge this pr to the trunk branch. |
Mysql5.7
Mysql8.0
|
|
💔 -1 overall
This message was automatically generated. |
|
@goiri Can you help to merge this pr into the trunk branch? Thank you very much! The SQL scripts involved in this pr have been verified in the environment of MySQL SQLServer |
|
@goiri Thank you very much for your help in reviewing the code! |
JIRA: YARN-11349. [Federation] Router Support DelegationToken With SQL.