-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11363. Remove unused TimelineVersionWatcher and TimelineVersion from hadoop-yarn-server-tests #5091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…from hadoop-yarn-server-tests
|
💔 -1 overall
This message was automatically generated. |
|
❌ |
cnauroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Jenkins reported deprecation warnings, but they are in files unchanged by this patch.
I'll plan on committing this to trunk, branch-3.3 and branch-3.2 next week.
|
Thanks @cnauroth for reviewing. |
|
LGTM +1 |
|
I committed this to trunk and branch-3.3, resolving a minor merge conflict due to differences in the code for @ashutoshcipher , thank you for cleaning up unused code. @slfan1989 , thank you for the help with code review. |
…from hadoop-yarn-server-tests (apache#5091) Reviewed-by: slfan1989 <55643692+slfan1989@users.noreply.github.com> Signed-off-by: Chris Nauroth <cnauroth@apache.org>
Description of PR
Remove unused TimelineVersionWatcher and TimelineVersion from hadoop-yarn-server-tests
JIRA - YARN-11363
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?