-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage #5069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
Please fix the failed unit test and checkstyle warn. |
|
💔 -1 overall
This message was automatically generated. |
...fs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
Outdated
Show resolved
Hide resolved
...fs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
Outdated
Show resolved
Hide resolved
...fs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
Outdated
Show resolved
Hide resolved
f09556b to
c3f2f36
Compare
|
💔 -1 overall
This message was automatically generated. |
|
The failed test looks related. Can you check? |
c3f2f36 to
ecaf2fe
Compare
|
💔 -1 overall
This message was automatically generated. |
5595855 to
842387b
Compare
2. We fixed two bugs in the processor of CacheManagerSectionProcessor to make sure the xml parsing fsimage.
842387b to
866f63f
Compare
|
💔 -1 overall
This message was automatically generated. |
@jojochuang Hi. I have checked the faild unit test. The failed UT hadoop.hdfs.TestLeaseRecovery2 is traced by HDFS-16853. The failed test does not involve the code I modified。 |
|
Hi @tomscut , please help us review this pr again when you are available, Thanks. |
Description of PR
How was this patch tested?
We add a test method in TestOfflineImageViewer.java. The meyhod name is testReverseXmlWithCacheManagerSection.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?