Skip to content

Conversation

@dannycjones
Copy link
Contributor

@dannycjones dannycjones commented Oct 6, 2022

Description of PR

Note: This is the same as #4925 but against branch-3.3.

When running integration tests against an S3-compatible endpoint without SSE support, tests would fail despite marking test.fs.s3a.encryption.enabled as false.

How was this patch tested?

Against eu-west-1, no special configuration. Encryption enabled.

Two test failures, look unrelated.

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   ITestS3APrefetchingInputStream.testRandomReadLargeFile:158 [Gauge named stream_read_blocks_in_cache with expected value 2] expected:<[2]L> but was:<[1]L>
[ERROR] Errors:
[ERROR]   ITestS3AFailureHandling.testMultiObjectDeleteLargeNumKeys » NullPointer
[INFO]
[ERROR] Tests run: 1143, Failures: 1, Errors: 1, Skipped: 186

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@dannycjones dannycjones marked this pull request as ready for review October 6, 2022 13:50
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 10m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 39m 36s branch-3.3 passed
+1 💚 compile 0m 34s branch-3.3 passed
+1 💚 checkstyle 0m 31s branch-3.3 passed
+1 💚 mvnsite 0m 44s branch-3.3 passed
+1 💚 javadoc 0m 35s branch-3.3 passed
+1 💚 spotbugs 1m 15s branch-3.3 passed
+1 💚 shadedclient 25m 48s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 37s the patch passed
+1 💚 compile 0m 29s the patch passed
+1 💚 javac 0m 29s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 17s the patch passed
+1 💚 mvnsite 0m 33s the patch passed
+1 💚 javadoc 0m 22s the patch passed
+1 💚 spotbugs 1m 8s the patch passed
+1 💚 shadedclient 25m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 7s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
111m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4977/1/artifact/out/Dockerfile
GITHUB PR #4977
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 7ff1fca53413 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 0c1fb26
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4977/1/testReport/
Max. process+thread count 532 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4977/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@dannycjones
Copy link
Contributor Author

Hey @steveloughran, this should be ready for backport. (backport of #4925)

@steveloughran steveloughran merged commit 2778bc8 into apache:branch-3.3 Oct 19, 2022
@dannycjones dannycjones deleted the HADOOP-18465-branch-3.3-fix-sse-skip-on-disabled-encryption branch October 19, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants