YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.#4843
Merged
goiri merged 17 commits intoapache:trunkfrom Sep 12, 2022
Merged
YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.#4843goiri merged 17 commits intoapache:trunkfrom
goiri merged 17 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Sep 1, 2022
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Sep 2, 2022
| long deadline = (long) (arrival + 1.05 * duration); | ||
| ReservationSubmissionRequest submissionRequest = | ||
| ReservationSystemTestUtil.createSimpleReservationRequest(reservationID, 4, | ||
| arrival, deadline, duration); |
| // Generate reserved resources | ||
| ClientRMService clientService = mockRM.getClientRMService(); | ||
| long arrival = Time.now(); | ||
| long duration = 60000; |
Member
There was a problem hiding this comment.
We probably want to have reasons for these constants even though is just a mock.
| */ | ||
| private SubClusterInfo getHomeSubClusterInfoByReservationId(String resId) | ||
| throws YarnException { | ||
| SubClusterInfo subClusterInfo = null; |
Member
There was a problem hiding this comment.
Declare it where we use it or even just return.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Please help to review the code again, thank you very much! |
goiri
approved these changes
Sep 6, 2022
goiri
reviewed
Sep 7, 2022
| String applyReservationId = reservationId.toString(); | ||
| Response listReservationResponse = | ||
| interceptor.listReservation(MockDefaultRequestInterceptorREST.QUEUE_DEDICATED_FULL, | ||
| applyReservationId, -1, -1, false, null); |
|
💔 -1 overall
This message was automatically generated. |
Member
|
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST doesn't look healthy. |
Contributor
Author
I will look into the cause as soon as possible and fix it. I checked the test report and found no key information. I added the exception log to print. If there is a problem, it can be easily located. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Can you help merge this pr into trunk branch? I am continuing to finish YARN-11226 on the basis of this pr. Thank you very much!
From a personal point of view, the change of this pr should not affect the operation of TestRouterWebServicesREST. |
goiri
reviewed
Sep 9, 2022
| } | ||
| }, 1000, 10 * 1000); | ||
| } catch (Exception e) { | ||
| LOG.error("Web app not running", e); |
Member
There was a problem hiding this comment.
Why do we do this? Isn't it clear enough with the "fail()" message?
Contributor
Author
There was a problem hiding this comment.
Why do we do this? Isn't it clear enough with the "fail()" message?
I understand your thoughts, you are right, the "fail()" message is enough, generally it is caused by timeout, I increased the timeout.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Thank you very much for helping to review the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.