HADOOP-11223. Create UnmodifiableConfiguration #473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milleruntime
changed the title
Author
|
Renaming this class to UnmodifiableConfiguration since it is not immutable. It more closely resembles the java unmodifiable collections: https://docs.oracle.com/javase/7/docs/api/java/util/Collections.html |
ctubbsii
reviewed
Jan 30, 2019
Member
There was a problem hiding this comment.
These are probably okay to proxy.
Member
There was a problem hiding this comment.
By that, I mean that is probably okay to provide an implementation that calls this.other.writeXml(...) instead of throwing UnsupportedOperationException for these methods.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
milleruntime
force-pushed
the
immutable-conf
branch
from
de10b99 to
e9a2ba3
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Member
|
Is Yetus just going to keep spamming this issue indefinitely, with it never being merged? If so, I'm going to stop following this issue. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Member
|
I think I might actually have to block @hadoop-yetus and @apache-yetus . It's so spammy and drowns out human conversation. I don't see value in its checks as a bot commenting in the thread for humans. It should run as an app instead, like Travis CI, etc. EDIT: blocking doesn't seem to remove the spammy comments from my view. |
|
🎊 +1 overall
This message was automatically generated. |
Member
|
Can somebody from Hadoop respond to this PR? Please either merge it or close it as rejected. The spam from the yetus bot is overwhelming, annoying, and unnecessary. |
Author
|
Closing to stop the yetus spam. |
Member
|
Thanks @milleruntime ; while I would have preferred a response from the Hadoop developers, I suppose that is the second best option. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
* Tests to benchmark the performance of the system consumers and producers. * Config to test the benchmark for the event hub system producer and consumer. SystemConsumerBench and SystemProducerBench provides base generic implementation to test the benchmark for the system producers and consumers. Any new system that needs benchmark test needs a properties file. The benchmark test itself is single threaded in the way it consumes and produces events. Scaling the benchmark tests right now involves running multiple processes of these tests in parallel. Right now we just calculate the event rate, But in future we could create a logging metrics registry to hookup other metrics and log them in console along with event rate while the benchmark tests are being run. Author: Srinivasulu Punuru <[email protected]> Reviewers: Jagadish <[email protected]>, Wei Song<[email protected]> Closes apache#473 from srinipunuru/benchmark.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.apache.org/jira/browse/HADOOP-11223 by creating an immutable Configuration class. This class will throw UnsupportedOperationException on any mutable method calls.
I am not sure what branch or version this is appropriate to apply to so I am doing a pull request against trunk.