Skip to content

HADOOP-18365. Update the remote address when a change is detected #4692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saintstack merged 6 commits into from
Aug 18, 2022
Merged

HADOOP-18365. Update the remote address when a change is detected #4692

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b610c8
HADOOP-18365. Update the remote address when a change is detected
Jul 25, 2022
590f5ba
Fix Checkstyle line length violation
Aug 4, 2022
168be14
Keep ConnectionId as Immutable for map key
Aug 6, 2022
1f1fdcf
Use final to protect immutable ConnectionId
Aug 6, 2022
cac2837
Use a stable hashCode to allow safe IP addr changes
Aug 8, 2022
03cf96b
Add test that updated address is used
Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,8 @@ private synchronized boolean updateAddress() throws IOException {
LOG.warn("Address change detected. Old: " + server.toString() +
" New: " + currentAddr.toString());
server = currentAddr;
// Update the remote address so that reconnections are with the updated address. This avoids thrashing.
remoteId.setAddress(currentAddr);
UserGroupInformation ticket = remoteId.getTicket();
this.setName("IPC Client (" + socketFactory.hashCode()
+ ") connection to " + server.toString() + " from "
Expand Down Expand Up @@ -1753,7 +1755,16 @@ public ConnectionId(InetSocketAddress address, Class<?> protocol,
InetSocketAddress getAddress() {
return address;
}


/**
* Used to update the remote address when an address change is detected.
*
* @param address the new address
*/
private void setAddress(InetSocketAddress address) {
this.address = address;
}

Class<?> getProtocol() {
return protocol;
}
Expand Down