Skip to content

HADOOP-18387. Fix incorrect placeholder in hadoop-common #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushtkn merged 3 commits into from
Aug 7, 2022
Merged

HADOOP-18387. Fix incorrect placeholder in hadoop-common #4679

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5899b2f
HADOOP-18387. Fix incorrect placeholder in hadoop-module.
Aug 2, 2022
820aaee
HADOOP-18387. Fix incorrect placeholder in hadoop-module.
Aug 3, 2022
dc5fad2
HADOOP-18387. Fix CheckStyle.
Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...mmon-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,9 @@ public <T extends FileSystem & Renewable> void removeRenewAction(
try {
action.cancel();
} catch (InterruptedException ie) {
LOG.error("Interrupted while canceling token for " + fs.getUri()
LOG.error("Interrupted while canceling token for {} filesystem." + fs.getUri()
Copy link
Contributor

@steveloughran steveloughran Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to move the fs.geturi to a param, not string concat

Copy link
Contributor Author

@slfan1989 slfan1989 Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help reviewing the code, I will fix it.

+ "filesystem");
LOG.debug("Exception in removeRenewAction: {}", ie);
LOG.debug("Exception in removeRenewAction.", ie);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...gistry/src/main/java/org/apache/hadoop/registry/server/services/RegistryAdminService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ protected void serviceStart() throws Exception {
bindingDiagnosticDetails(),
dumpRegistryRobustly(true));

LOG.error(" Failure {}", e, e);
LOG.error(" Failure {}", e.getMessage(), e);
Copy link
Contributor

@steveloughran steveloughran Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1. to this change

L227 is valid; it calls e.toString on demand and handles any errors raised. the second e forms the stack trace.

e.getMessage() is null on some exceptions, like NPE

Copy link
Contributor Author

@slfan1989 slfan1989 Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert it.

LOG.error(message);

// TODO: this is something temporary to deal with the problem
Expand Down
2 changes: 1 addition & 1 deletion ...webapp/src/main/java/org/apache/hadoop/yarn/appcatalog/application/YarnServiceClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public YarnServiceClient() {
try {
asc = new ApiServiceClient(conf);
} catch (Exception e) {
LOG.error("Error initialize YARN Service Client: {}", e);
LOG.error("Error initialize YARN Service Client.", e);
}
}

Expand Down