MAPREDUCE-7391. TestLocalDistributedCacheManager failing after HADOOP-16202#4472
Merged
steveloughran merged 3 commits intoapache:trunkfrom Jun 22, 2022
Conversation
…-16202 Mocking broke with the move the builder. Took the opportunity to clean up the test class with * use of lambda expressions for answers where they were short enough * constant for file contents * return that data's length in the getFileStatus calls * javadocs for the tests cases which didn't have them. Change-Id: Iaa64c97bb011322d3dbc494b163325ed530fdf6e
…-16202 Fixed the checkstyle errors. These weren't new, but as the old code was moved they triggered the failure. Refactored the code in question so there's less duplication; same for the creation of the mock file status. Change-Id: I79672fca3d67ac9aac2566e05f6073f7078b65d7
Contributor
Author
|
@ayushtkn @mukund-thakur could you two review this. test failure on trunk/branch-3.3 |
mukund-thakur
approved these changes
Jun 21, 2022
Contributor
mukund-thakur
left a comment
mukund-thakur
left a comment
There was a problem hiding this comment.
LGTM +1, pending one minor comment.
| @SuppressWarnings("deprecation") | ||
| public class TestLocalDistributedCacheManager { | ||
|
|
||
| public static final byte[] TEST_DATA = "This is a test file\n".getBytes(); |
Contributor
Author
There was a problem hiding this comment.
sorry, IDE did that without me noticing
ayushtkn
approved these changes
Jun 22, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Changes LGTM.
Merge once you sort out the public->private stuff
| * Recursive delete of a path. | ||
| * For safety, paths of length under 5 are rejected. | ||
| * @param file path to delete. | ||
| * @throws IOException IO failure |
Member
There was a problem hiding this comment.
btw This delete method never throws IOE, it is just there as a dummy in the method signature
Change-Id: I2b9d57bd9f0c44122491a3d82c32cc9ae24e33db
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Jun 22, 2022
…-16202 (#4472) Fixing a mockito-based test which broke when HADOOP-16202 changed the methods being invoked. Contributed by Steve Loughran
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…-16202 (apache#4472) Fixing a mockito-based test which broke when HADOOP-16202 changed the methods being invoked. Contributed by Steve Loughran
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mocking broke with the move to the builder.
Took the opportunity to clean up the test class with