HDFS-16637. TestHDFSCLI#testAll consistently failing

[virajjasani]

Description of PR

2022-06-19 15:41:16,183 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(146)) - Detailed results:
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(147)) - ----------------------------------

2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(156)) - -------------------------------------------
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(157)) -                     Test ID: [629]
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(158)) -            Test Description: [printTopology: verifying that the topology map is what we expect]
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(159)) - 
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(163)) -               Test Commands: [-fs hdfs://localhost:51486 -printTopology]
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(167)) - 
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(174)) - 
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(178)) -                  Comparator: [RegexpAcrossOutputComparator]
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(180)) -          Comparision result:   [fail]
2022-06-19 15:41:16,184 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(182)) -             Expected output:   [^Rack: \/rack1\s*127\.0\.0\.1:\d+\s\([-.a-zA-Z0-9]+\)\s*127\.0\.0\.1:\d+\s\([-.a-zA-Z0-9]+\)]
2022-06-19 15:41:16,185 [Listener at localhost/51519] INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(184)) -               Actual output:   [Rack: /rack1
   127.0.0.1:51487 (localhost) In Service
   127.0.0.1:51491 (localhost) In Service

Rack: /rack2
   127.0.0.1:51500 (localhost) In Service
   127.0.0.1:51496 (localhost) In Service
   127.0.0.1:51504 (localhost) In Service

Rack: /rack3
   127.0.0.1:51508 (localhost) In Service

Rack: /rack4
   127.0.0.1:51512 (localhost) In Service
   127.0.0.1:51516 (localhost) In Service

]

How was this patch tested?

UT

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	37m 37s		trunk passed
+1 💚	shadedclient	56m 28s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	18m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 16s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		81m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4466/1/artifact/out/Dockerfile
GITHUB PR	#4466
Optional Tests	dupname asflicense unit codespell detsecrets xmllint
uname	Linux 8665b0c30282 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / faf0292
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4466/1/testReport/
Max. process+thread count	706 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4466/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[ZanderXu]

Thanks @virajjasani for your work.
LGTM.
@jianghuazhu @tomscut This bug is introduced by HDFS-16581, please help to review this PR, thanks.

[ayushtkn]

LGTM.
The test failed in the Jenkins report of the patch breaking it...
Will commit by EOD if no further comments.

[tomscut]

LGTM.

[jianghuazhu]

Thanks again @ayushtkn .
I will be very careful in the future.

[steveloughran]

might be good to add a comment in the file generating the output as to which tests need to be updated