-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18300. Upgrade Gson dependency to version 2.9.0 #4454
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update here as well
https://github.com/apache/hadoop/blob/trunk/LICENSE-binary#L234
Thanks for pointer, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, If the Jenkins doesn't report any failures.
💔 -1 overall
This message was automatically generated. |
+1 trunk, branch-3.3 and branch-3.2 are all currently on GSON 2.8.9 and can take a backward-compatible upgrade to 2.9.0. I'll plan on committing to those 3 branches. |
Thanx @cnauroth for giving a check, just give a check to the Yarn test failure before merging, the other one I know isn't related. In case interested Hive too uses Gson and if you folks are interested we can keep the version in sync there as well: Hive is moving to hadoop 3.1.x line to 3.3.x line. :-) |
@ayushtkn , I forgot to mention that test failures look unrelated to me, but I'll be clarifying with an independent test run before I commit. Thanks for the tip on Hive. I'll check it out. |
I've confirmed that the failure in |
Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Chris Nauroth <[email protected]> (cherry picked from commit 77d1b19)
Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Chris Nauroth <[email protected]> (cherry picked from commit 77d1b19) (cherry picked from commit d41e0a9)
Thank you for the reviews and merging PR! |
Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Chris Nauroth <[email protected]>
Description of PR
Upgrade Gson dependency to version 2.9.0
How was this patch tested?
Presubmit/CI
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?