HADOOP-18288. Total requests and total requests per sec served by RPC servers#4431
Merged
tomscut merged 5 commits intoapache:trunkfrom Jun 18, 2022
Merged
HADOOP-18288. Total requests and total requests per sec served by RPC servers#4431tomscut merged 5 commits intoapache:trunkfrom
tomscut merged 5 commits intoapache:trunkfrom
Conversation
...-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
|
||
| NameNodeAdapter.getRpcServer(nn).refreshCallQueue(configuration); | ||
| assertEquals(1, NameNodeAdapter.getRpcServer(nn).getTotalRequests()); | ||
| assertTrue(NameNodeAdapter.getRpcServer(nn).getTotalRequests() > 0); |
Contributor
There was a problem hiding this comment.
if you have an assertion where a useful message isn't autogenerated the way assertequals does, afraid you will need to add a message or use assertJ to describe the assert. sorry.
Contributor
Author
There was a problem hiding this comment.
I agree, this is bit painful for debugging purpose. Updated with assertJ as it has better APIs to deal with such conditions (assertThat(x).isGreaterThan(y)).
Updated with the same, thanks for the suggestion @steveloughran
Contributor
There was a problem hiding this comment.
thanks! it is pretty verbose for the little things, but i find assertj lovely for complex things, especially collections
steveloughran
requested changes
Jun 15, 2022
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
javadocs good, but now you've moved to assertTrue i have to esk for the failure message for the assert. think of whoever tries to debug a failing jenkins build: what information do they need.
assertj asserts are great here, FWIW
tomscut
reviewed
Jun 16, 2022
Contributor
tomscut
left a comment
tomscut
left a comment
There was a problem hiding this comment.
On the whole, it looks good to me. Add some comments.
| long totalRequestsDiff = currentTotalRequests - lastSeenTotalRequests; | ||
| lastSeenTotalRequests = currentTotalRequests; | ||
| if ((currentTime - lastExecuted) > 0) { | ||
| double totalRequestsPerMillis = |
Contributor
There was a problem hiding this comment.
The unit here is second, so the variable name should be changed.
| try { | ||
| RpcMetrics rpcMetrics = server.getRpcMetrics(); | ||
| assertEquals(0, rpcMetrics.getTotalRequests()); | ||
| assertEquals(0.0, rpcMetrics.getTotalRequestsPerSecond(), 0.0); |
Contributor
There was a problem hiding this comment.
RpcMetrics#getTotalRequestsPerSecond return long, so we can make some change.
Suggested change
| assertEquals(0.0, rpcMetrics.getTotalRequestsPerSecond(), 0.0); | |
| assertEquals(0, rpcMetrics.getTotalRequestsPerSecond()); |
Contributor
Author
|
Thanks @tomscut, addressed comments. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
+1 from me, merge into trunk and branch-3.3 |
Contributor
|
Thanks @virajjasani for your contribution! Thanks @steveloughran for your review! |
Contributor
|
Hi @virajjasani , I found some conflicts when cherry-pick this to branch-3.3. For security, could you please submit a new PR to branch-3.3 separately? Thanks a lot! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
… servers (apache#4431) Reviewed-by: Steve Loughran <stevel@apache.org> Signed-off-by: Tao Li <tomscut@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
RPC Servers provide bunch of useful information like num of open connections, slow requests, num of in-progress handlers, RPC processing time, queue time etc, however so far it doesn't provide accumulation of all requests as well as current snapshot of requests per second served by the server. Exposing them would benefit from operational viewpoint in identifying how busy the servers have been and how much load they are currently serving in the presence of cluster wide high load.
How was this patch tested?
Local dev cluster and UT.
For code changes: