Skip to content

MAPREDUCE-7388. Remove unused variable _eof in GzipCodec.cc#4429

Merged
aajisaka merged 2 commits intoapache:trunkfrom
cfg1234:trunk
Jul 8, 2022
Merged

MAPREDUCE-7388. Remove unused variable _eof in GzipCodec.cc#4429
aajisaka merged 2 commits intoapache:trunkfrom
cfg1234:trunk

Conversation

@cfg1234
Copy link
Contributor

@cfg1234 cfg1234 commented Jun 11, 2022

JIRA: MAPREDUCE-7388 remove unused variable _eof in GzipCodec.cc

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 40m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 37m 49s trunk passed
+1 💚 compile 1m 14s trunk passed
+1 💚 mvnsite 0m 52s trunk passed
+1 💚 shadedclient 59m 2s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 30s the patch passed
+1 💚 compile 0m 55s the patch passed
+1 💚 cc 0m 55s the patch passed
+1 💚 golang 0m 55s the patch passed
+1 💚 javac 0m 55s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 31s the patch passed
+1 💚 shadedclient 19m 0s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 3m 5s hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚 asflicense 0m 51s The patch does not generate ASF License warnings.
125m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4429/1/artifact/out/Dockerfile
GITHUB PR #4429
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname Linux 27411dcf107c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1b94011
Default Java Red Hat, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4429/1/testReport/
Max. process+thread count 637 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4429/1/console
versions git=2.9.5 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@cfg1234 cfg1234 marked this pull request as draft June 13, 2022 12:32
@cfg1234
Copy link
Contributor Author

cfg1234 commented Jun 13, 2022

@eddyxu @toddlipcon @phunt

@cfg1234
Copy link
Contributor Author

cfg1234 commented Jun 13, 2022

@ayushtkn @saintstack

@cfg1234 cfg1234 marked this pull request as ready for review June 14, 2022 11:19
@cfg1234
Copy link
Contributor Author

cfg1234 commented Jun 22, 2022

@aajisaka @tomscut This is a minor code change, unit tests, javadoc issues have little to do with this pr, please help to review the code, thank you very much!

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 42m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 31s trunk passed
+1 💚 compile 1m 15s trunk passed
+1 💚 mvnsite 0m 52s trunk passed
+1 💚 shadedclient 59m 33s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 30s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 cc 0m 56s the patch passed
+1 💚 golang 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 31s the patch passed
+1 💚 shadedclient 18m 57s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 3m 5s hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚 asflicense 0m 53s The patch does not generate ASF License warnings.
128m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4429/2/artifact/out/Dockerfile
GITHUB PR #4429
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname Linux 766a33bd6ffd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6dd151a
Default Java Red Hat, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4429/2/testReport/
Max. process+thread count 689 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4429/2/console
versions git=2.9.5 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aajisaka aajisaka changed the title remove unused variable _eof MAPREDUCE-7388. Remove unused variable _eof Jul 8, 2022
@aajisaka aajisaka changed the title MAPREDUCE-7388. Remove unused variable _eof MAPREDUCE-7388. Remove unused variable _eof in GzipCodec.cc Jul 8, 2022
@aajisaka aajisaka merged commit fac8958 into apache:trunk Jul 8, 2022
@aajisaka
Copy link
Member

aajisaka commented Jul 8, 2022

@cfg1234 Thank you for your contribution!

@aajisaka
Copy link
Member

aajisaka commented Jul 8, 2022

Rethinking this, let me revert the commit. The variable is protected and possible to be used from derived class.

aajisaka added a commit that referenced this pull request Jul 8, 2022
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
)

Co-authored-by: cWX456268 <chenfengge1@huawei.com>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants