HDFS-16628 RBF: Correct target directory when move to trash for kerberos login user.#4424
Merged
Hexiaoqiao merged 2 commits intoapache:trunkfrom Jun 15, 2022
Merged
Conversation
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
reviewed
Jun 10, 2022
Contributor
Hexiaoqiao
left a comment
Hexiaoqiao
left a comment
There was a problem hiding this comment.
@zhangxiping1 Thanks for your report and contribution. Good catch here.
Leave some comments inline. FYI.
| } | ||
|
|
||
| @Test | ||
| public void testMoveToTrashNoMountPointWithKerBoersUser() throws IOException, |
Contributor
There was a problem hiding this comment.
testMoveToTrashNoMountPointWithKerBoersUser -> testMoveToTrasWithKerberosUser?
a. IMO, this case is not related with NoMountPoint or not, right?
b. KerBoers -> Kerberos.
Contributor
Author
There was a problem hiding this comment.
OK, thank you for your correction.
| public void testMoveToTrashNoMountPointWithKerBoersUser() throws IOException, | ||
| URISyntaxException, InterruptedException { | ||
| //Constructs the structure of the KerBoers user name | ||
| String kerBoersUser = "randomUser/dev@HADOOP.COM"; |
Contributor
There was a problem hiding this comment.
Suggest to correct KerBoers to Kerberos. Both of the following spell issues.
| DFSClient currentUserClientNs1 = nn1Context.getClient(); | ||
|
|
||
| currentUserClientNs0.setOwner("/", ugi.getShortUserName(), ugi.getShortUserName()); | ||
| currentUserClientNs1.setOwner("/", ugi.getShortUserName(), ugi.getShortUserName()); |
Contributor
There was a problem hiding this comment.
If only one DFSClient and NamenodeContext is enough for this unit test?
Contributor
Author
There was a problem hiding this comment.
It is a good idea to set the test user permissions for both subsets. Give test users permission to create both subCluster Trash directories, otherwise there may be some false positives.
| Configuration routerConf = routerContext.getConf(); | ||
| FileSystem fs = DFSTestUtil.getFileSystemAs(ugi, routerConf); | ||
| Trash trash = new Trash(fs, routerConf); | ||
| assertTrue(trash.moveToTrash(filePath)); |
Contributor
There was a problem hiding this comment.
Suggest to check if the final trash directory entries are expected: /user/randomUser/.Trash/?
zhangxiping1
changed the title
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
cc @Hexiaoqiao It has been modified. Please help to merge it. Thank you very much |
Hexiaoqiao
approved these changes
Jun 14, 2022
Contributor
Hexiaoqiao
left a comment
Hexiaoqiao
left a comment
There was a problem hiding this comment.
LGTM. +1. Will commit if no more other comments for a while.
Contributor
Author
|
Ok, thank you @Hexiaoqiao |
Hexiaoqiao
changed the title
Contributor
|
Committed to trunk. Thanks @zhangxiping1 for your report and contribution. |
xinglin
pushed a commit
to xinglin/hadoop
that referenced
this pull request
Oct 5, 2022
…ros login user. (apache#4424). Contributed by Xiping Zhang. (cherry picked from commit f8c7e67)
xinglin
pushed a commit
to xinglin/hadoop
that referenced
this pull request
Oct 9, 2022
…ros login user. (apache#4424). Contributed by Xiping Zhang. (cherry picked from commit f8c7e67)
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…ros login user. (apache#4424). Contributed by Xiping Zhang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDFS-16628 RBF: kerbose user remove Non-default namespace data failed