HADOOP-18284. Remove Unnecessary semicolon ';' #4422
Merged
ayushtkn merged 7 commits intoapache:trunkfrom Jun 29, 2022
Merged
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
slfan1989
changed the title
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@ayushtkn please help me to review this pr, thank you very much! |
ayushtkn
reviewed
Jun 17, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
dropped a minor comment,
+1 once addressed
|
|
||
| private static class MyOptions { | ||
| String rootDir = GenericTestUtils.getTestDir().getAbsolutePath();; | ||
| private String rootDir = GenericTestUtils.getTestDir().getAbsolutePath();; |
Member
There was a problem hiding this comment.
no need to add private here as part of this change
| private int maxRec; | ||
| private int softLimit; | ||
| boolean spillInProgress;; | ||
| private boolean spillInProgress; |
Member
There was a problem hiding this comment.
no need to add private here as part of this change
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestion, I will fix it.
Contributor
Author
|
Hi，@ayushtkn When doing this pr, I found that the test report has the following errors： Failed junit tests These two errors are both introduced by HDFS-16563， PR:#4241, Because HDFS-16563 modifies the token expiration prompt, the is expired keyword fails in the assertion. TestJHSSecurity I submitted a PR to fix, JIRA:MAPREDUCE-7387. PR:#4428 Thank you again！ |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Member
|
@slfan1989 can you rebase and retrigger the build once. give a check to the checkstyle warnings if they are induced by this patch |
Contributor
Author
Thank you for your help to review the code, I will do the rebase operation and fix checkstyle. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Hi, @ayushtkn, Thank you very much for your help reviewing the code, I read the test report about the checkstyle issue. 1st 2nd These two places should not need to increase the private modifier. Please help me review the code again. |
ayushtkn
approved these changes
Jun 21, 2022
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Changes LGTM.
Checkstyle warnings are false alarms, aren't induced by this patch
Contributor
Author
|
Hi, @ayushtkn Can you help me merge this pr into trunk branch？Thank you very much! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…uted by fanshilun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA:HADOOP-18284. Remove Unnecessary semicolon ';'
while reading the code, I found a very tiny optimization point, part of the code contains 2 semicolons at the end, I will fix it. Because this change is simple, I fixed it in One JIRA.
The code looks like this: