HDFS-16627. Improve BPServiceActor#register log to add NameNode address.#4419
Merged
Hexiaoqiao merged 4 commits intoapache:trunkfrom Jun 11, 2022
Merged
HDFS-16627. Improve BPServiceActor#register log to add NameNode address.#4419Hexiaoqiao merged 4 commits intoapache:trunkfrom
Hexiaoqiao merged 4 commits intoapache:trunkfrom
Conversation
ZanderXu
reviewed
Jun 9, 2022
Contributor
ZanderXu
left a comment
ZanderXu
left a comment
There was a problem hiding this comment.
LGTM. Thanks @slfan1989
|
💔 -1 overall
This message was automatically generated. |
Hexiaoqiao
reviewed
Jun 9, 2022
Contributor
Hexiaoqiao
left a comment
Hexiaoqiao
left a comment
There was a problem hiding this comment.
@slfan1989 Thanks for your contributions. Leave one nit comment about format, others make sense to me. Will +1 once the format issue fixed. Thanks
| DatanodeRegistration newBpRegistration = bpos.createRegistration(); | ||
|
|
||
| LOG.info(this + " beginning handshake with NN"); | ||
| LOG.info("{} beginning handshake with NN:{}", this, nnAddr); |
Contributor
There was a problem hiding this comment.
Please keep the same format of log, such as delete the blank at end of a sentence, leave one blank between two words. such as,
L819: LOG.info("{} beginning handshake with NN: {}", this, nnAddr);
L831: LOG.info("Problem connecting to server: {}", nnAddr);
Contributor
Author
There was a problem hiding this comment.
@Hexiaoqiao Thanks for your help reviewing the code, I will fix it.
Contributor
Author
Thank you for help to review the code! |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@Hexiaoqiao Please help me review the code again! |
tomscut
approved these changes
Jun 10, 2022
Contributor
|
The latest build seems throw some warning. Try to trigger jenkins again. Let's wait what it will say. |
Contributor
Author
no problem, i will re-trigger jenkins! |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
Hi, @Hexiaoqiao Thank you very much for your help in reviewing the code. I read the compilation report carefully and can confirm that the compilation error of java doc has nothing to do with this pr. java doc has become more strict in the compilation environment of jdk11, java doc will be run 2 times after a pr commit. 1st run hadoop-hdfs in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. 2nd run hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. In 2 runs will report the following error I try to fix it in this pr(#4423), after solving the error, the java doc can be compiled successfully with jdk11. |
Hexiaoqiao
changed the title
Contributor
It makes sense to me. Committed to trunk. Thanks @slfan1989 for your contribution, and thanks @tomscut, @ZanderXu for your reviews. |
Contributor
Author
|
@Hexiaoqiao @tomscut @ZanderXu Thanks for helping to review the code！ |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…ss. (apache#4419). Contributed by fanshilun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA:HDFS-16627. improve BPServiceActor#register Log Add NN Addr.
When I read the log, I think the Addr information of NN should be added to make the log information more complete.
The log is as follows: